search

pieper / cvg

constructive volume geometry tool
0 stars 1 forks source link

bounds checking. #10

Closed bebbi closed 9 years ago

bebbi commented 9 years ago

Every expression checks its max bounds. Non-leaf nodes evaluate downstream expressions. Expressions with no foreseeable bounds have a bound of infinity. on first check, expression caches bounds for performance.

bebbi commented 9 years ago

Is this along your #3 idea? I think it could benefit from some review. See also tests.

bebbi commented 9 years ago

ps just realized that we can cache bounds when I wanted to pull. With this, the rotation bounds can probably be refined - maybe you have a better approach for that.

pieper commented 9 years ago

Hey Stefan -

I put some notes in the line comments. Let me know what you think.

I'm thinking something like

https://github.com/Kitware/VTK/blob/28aebaa3c3a722edd57275c35c4e7dbe1cf8cabc/Common/DataModel/vtkImplicitFunction.h

-Steve

On Thu, Jun 11, 2015 at 11:27 AM, Stefan notifications@github.com wrote:

ps just realized that we can cache bounds when I wanted to pull. With this, the rotation bounds can probably be refined - maybe you have a better approach for that.

— Reply to this email directly or view it on GitHub https://github.com/pieper/cvg/pull/10#issuecomment-111173263.

bebbi commented 9 years ago

branch still exists for reference