search

pier-oliviert / PHRefreshTriggerView

This is an alternate to EGORefreshTableView that uses gestureRecognizer instead of UIScrollView's delegate.
http://www.pothibo.com
34 stars 6 forks source link

index in UItableview gets obscured #5

Open gilg opened 12 years ago

gilg commented 12 years ago

Very elegant solution to pull-to-refresh!

However, I have the following problem: I have a table with an index on the right hand side. While in "loading" state, the index gets obscured. Every second letter becomes a "." (dot). Didn't see that sectionForSectionIndexTitle() gets called. After the pull-to-refresh is released, everything returns to normal.

Any idea why this might be happening?

pier-oliviert commented 12 years ago

Ok I got to try this out a bit. What I can see is that the contentInset property influences the way the index is positioned.

Basically, the UIView is being shrank when the content inset is set on line #86 in PHRefreshGestureRecognizer.m is set. One way to resolves this issue without any regression would be to expand the height of the PHRefreshTriggerView by 64 px when the load is triggered.

Since I'm on vacation right now, I don't really have the time to do it until next week. If you can wait, I'll have a fix commited on monday.

gilg commented 12 years ago

No worries. Enjoy your vacation. It can wait until Monday.

Regards, Gil Gabay

On 23 באוג 2012, at 17:54, Pier-Olivier Thibault notifications@github.com wrote:

Ok I got to try this out a bit. What I can see is that the contentInset property influences the way the index is positioned.

Basically, the UIView is being shrank when the content inset is set on line

86 in PHRefreshGestureRecognizer.m is set. One way to resolves this issue

without any regression would be to expand the height of the PHRefreshTriggerView by 64 px when the load is triggered.

Since I'm on vacation right now, I don't really have the time to do it until next week. If you can wait, I'll have a fix commited on monday.

— Reply to this email directly or view it on GitHubhttps://github.com/pothibo/PHRefreshTriggerView/issues/5#issuecomment-7972258.

pier-oliviert commented 12 years ago

I just browse some other project that handle pull to refresh and they all seem to do it the same way I do it (which means they all have the same issue with indexes being resized). At first, I thought that changing PHRefreshTriggerView would be a good idea, but now that I think about it, I feel this would bring more harm than good.

I can see it breaking UI in different situation if I apply this patch.

Maybe for your case you could make the modification on your local files?

gilg commented 12 years ago

I checked and it is indeed a behavior seen elsewhere also. For example, if you rotate the contacts app to landscape mode, then you will get the same problem, since the index cannot fit in that orientation. Thus it isn't the fault of PHRefreshTriggerView.

...Nevertheless, the problem is there, and I am wondering how to solve it.

On Mon, Aug 27, 2012 at 4:08 PM, Pier-Olivier Thibault < notifications@github.com> wrote:

I just browse some other project that handle pull to refresh and they all seem to do it the same way I do it (which means they all have the same issue with indexes being resized). At first, I thought that changing PHRefreshTriggerView would be a good idea, but now that I think about it, I feel this would bring more harm than good.

I can see it breaking UI in different situation if I apply this patch.

Maybe for your case you could make the modification on your local files?

— Reply to this email directly or view it on GitHubhttps://github.com/pothibo/PHRefreshTriggerView/issues/5#issuecomment-8055190.

pier-oliviert commented 12 years ago

Agreed that this is an important issue. However this bug is going to be hard to tackle since the index view is an hidden view within UITableView hierarchy with an autoresizingMask set.

I'll have to think of an alternative way to achieve the same result