pierky / arouteserver

A tool to automatically build (and test) feature-rich configurations for BGP route servers.
https://arouteserver.readthedocs.org/
GNU General Public License v3.0
284 stars 46 forks source link

import limit is not set if peeringdb not found #105

Closed budiwijaya closed 2 years ago

budiwijaya commented 2 years ago

Using arouteserver version 1.14.0

When a client is not having a peeringdb record, the import limit will not be set.

My general.yaml config:

...
    max_prefix:
      action: "shutdown"
      restart_after: 5
      general_limit_ipv4: 1000
      general_limit_ipv6: 100
      count_rejected_routes: false
      peering_db:
        enabled: true
...

Example one of the clients that did not have peeringdb record: AS136127

Config generated:

...
protocol bgp AS136127_1 {
        description "xxxx";

        local as xxxx;
        neighbor 103.x.x.x as 136127;
        rs client;

        passive on;
        ttl security off;

        interpret communities off;

        # ---------------------------------------
        ipv4 {
        table master4;

        import table on;

        import keep filtered on;

        import filter receive_from_AS136127_1;
        export filter announce_to_AS136127_1;

        # ---------------------------------------
        };

                }
...

The documentation says, it should fallback to the value of general_limit_ipv4.

pierky commented 2 years ago

Hello @budiwijaya, thanks for filing this issue.

I've just pushed a fix to a new branch, commit 14aec5f8b388658323cafe975e6d9469e5c44d09. The CI/CD pipeline is running now: if everything goes well, I'll promote it to master and a new release will be shipped hopefully in a few hours.

pierky commented 2 years ago

v1.14.1 is out, it should fix the issue.