pierky / arouteserver

A tool to automatically build (and test) feature-rich configurations for BGP route servers.
https://arouteserver.readthedocs.org/
GNU General Public License v3.0
288 stars 46 forks source link

Update ixf_member_list_from_clients.py & Create rtt_getter.c #67

Open happyhater opened 3 years ago

happyhater commented 3 years ago

Hello,

I created rtt_getter in C to works on OpenBSD (natively) or even on Linux. Also there's an major edit for IX-F where I think are mandatory to use 'if_speed',

Thanks! --z

pierky commented 3 years ago

Hello @happyhater,

just a clarification on the Euro-IX JSON file. You say

Also there's an major edit for IX-F where I think are mandatory to use 'if_speed',

Where did you see this?

I've recently added a test case that's used to validate the output of IXFMemberListFromClientsCommand.build_json (so, the sub-command ixf-member-export): the test uses the Euro-IX API endpoint from https://ixpdb.euro-ix.net/en/validator/ to submit the JSON and verify that no errors are reported, and it actually reports no errors.

Also, looking at the 1.0 specification I can't see if_speed being mentioned as a mandatory/required attributes of any structure in the schema.

Could you clarify what makes you thinking that if_speed is a required field? Thanks

happyhater commented 3 years ago
                            "if_speed": {
                              "description": "Speed of the interface or LAG in Mb, i.e. 10G = 10000",
                              "type": "integer"
                            },

That's true, this function are used only on PDB. #L262 In my opinion I think is useful for showing the port speed with Internet Exchange, most of them don't know what is their 'if_speed' allocated, or use a false setup.