pierky / arouteserver

A tool to automatically build (and test) feature-rich configurations for BGP route servers.
https://arouteserver.readthedocs.org/
GNU General Public License v3.0
288 stars 46 forks source link

Textual representation HTML formatting problem in "Reject reasons" table #71

Closed bluikko closed 3 years ago

bluikko commented 3 years ago

There is some problem with the HTML template: the "Reject reasons" table is rendered wrong.

At least on a 1920x1080 screen (no scaling) all the rows after the first are split with a newline after "ID" column: image

The configuration for reject reasons is using default values from the docker image run. One notable difference to https://arouteserver.readthedocs.io/en/latest/_static/examples_rich.html is that the example does not include any of the communities: it just includes ID and reason.

Using Chromium 90 on Windows.

Will try to take a look at this in more detail at some point.

bluikko commented 3 years ago

There seems to be an extra <tr> element in the rendered HTML file:

  <tr>
    <td align=right>1</td>
      <tr> <--- here
    <td>Invalid AS_PATH length</td>
    <td>65520:1</td>
    <td>rt:65520:1</td>
[...]

In the macro write_communities_table_row the list of dyn_val + three communities is wrapped inside a table row. This works for the other tables but messes up the "Reject reasons" table - because the ID as the first column would be left on a row of its own.

pierky commented 3 years ago

This is WIP in the dev branch, it should be already fixed. Details in https://github.com/pierky/arouteserver/pull/68#issuecomment-825135622

pierky commented 3 years ago

This should be fixed now in v1.5.1. Thanks for the feedback (and for proposing the solution!)

bluikko commented 3 years ago

Looks good indeed, didn't get round to updating until 1.10.0.

pierky commented 3 years ago

Looks good indeed, didn't get round to updating until 1.10.0.

Thanks for the feedback!