pierobot / mangapie

This is a self-hosted server for archived manga.
BSD 3-Clause "New" or "Revised" License
65 stars 9 forks source link

Subfolder Management #148

Closed donotos closed 4 years ago

donotos commented 4 years ago

Hello.

Since we can now restrict library access per users i started integrating to mangapie my old collection of finished mangas, but in some of them i have subfolders for the scans in my mother tongue (french). They are accessible and displayed but it is not really practical, so i though about a change. you have actually implemented a tab system witch is [Information][Files][Comment] in mobile view or [Files][Comment] in computer view. It would be great if a tab was added for all subfolder, like if i have a subfolder named "FR" a tab [FR] would be created witch would display the content of said subfolder instead of having everything in [Files].

Actually if i have a subfolder named "FR" and my zip files in this subfolder named AAA.zip, it will take the first image of that archive for the cover instead of the first image of BBB.zip in the main folder. Mangapie should not search the subfolders contents for a cover.

Thanks.

pierobot commented 4 years ago

The default cover will always be the first archive sorted lexicographically. There are cases where archives are split between subfolders and so it looks for archives in subfolders as well.

You can change the default cover by clicking on the icon that looks like a pencil and going to the covers tab.

Should I add a user option for exclusions?

donotos commented 4 years ago

Ok so if you can't exclude subfolder i don't think it's relevant to add an option just for that. like you said i can just rename my files or manually set the cover if i want to achieve what i want.

What do you think about the tab per subfolder option?

pierobot commented 4 years ago

I'd rather keep tabs for other pages. What do you think about adding a tree or list view for the archives? Would that help?

donotos commented 4 years ago

it's a good idea actually. having a choice in the way you display your chapter list would be nice. You could add a compact list view (without preview thumbs), a normal list (like in the home page) and a tree view for series with subfolders.

kurim commented 4 years ago

This might be a helpful function, if it has [FR]/[DE]/[whatelse] in the foldername it might be enough to set a country flag or as mentioned multi tabs...

\folder[Manganame[FR]cbz/r \folder[Manganame[DE]cbz/r

Maybe as an optical: image

donotos commented 4 years ago

a second row of tabs looks good, but instead of a "flag" system i find it better to go back to my first proposal to generate a tab per subfolder using the name of the folder as tab label, it would make it more flexible.

pierobot commented 4 years ago

The problem with tabs is that depending on the # of tabs or length of their titles they can start to look ugly. I decided to just use the pills. I don't know if that's what donotos was suggesting I do. At the time, I understood he wanted the folders to be next to the Files and Comments pills.

I don't think I'll be adding flags since that would require too much work because people could be using folders for sorting other than by language.

This is how it currently looks. The lists look a little empty in some parts but I'll probably add something else.

Screen Shot 2020-05-04 at 22 07 26

donotos commented 4 years ago

looks nice to me. you could add the reading status to that. does the "test" button represent a subfolder? by the way since you are implementing a new view be cautious of that:

Capture d’écran 2020-05-05 à 16 39 16
pierobot commented 4 years ago

Yes it's a folder. I will add a reading status.

You can make a new issue for those long strip covers.

pierobot commented 4 years ago

https://github.com/pierobot/mangapie/commit/8a56bfea8685643a94822bf7913ce975ae678a5f adds pills for the top most directories.