pierobot / mangapie

This is a self-hosted server for archived manga.
BSD 3-Clause "New" or "Revised" License
65 stars 9 forks source link

Notifications improvements #152

Closed donotos closed 4 years ago

donotos commented 4 years ago

Hello.

I'd like to suggest some improvements in the notification feature.

first, let's say that there is 5 new chapters for one manga, right now the notification center will display 5 identical entries. it would be nice if it would display only one entry per mangas with some numbers if there is more than one new chapter.

second, displaying the total number of new chapter on the notification icon (not vital but would still be nice).

pierobot commented 4 years ago

Sure, I can add that once I get the chance.

kurim commented 4 years ago

how about to add a email-notification function if a new manga is available?

pierobot commented 4 years ago

That's actually a good idea. :+1:

pierobot commented 4 years ago

image image

This is how it looks like so far. Should I leave the :tada: emoji? :thinking: The reason I don't have any archive names is to keep the rows slim and not make the database rows too large. What I plan on doing is having a counter on the directory pills that say how many archives are unread. image

donotos commented 4 years ago

Yes that looks good but it would be nice to keep the cover, it make it easier to identify what you are reading. You could add the last 2 archive name since it would give more space with the cover. It does not mater if it take space actually since notifications are not meant to be kept accumulating.

pierobot commented 4 years ago

I can add a thumbnail, but it won't be as large as the read history thumbnail because I plan on adding more notifications for things that are not just related to a series.

donotos commented 4 years ago

Sure. A half size one would be good enough.

pierobot commented 4 years ago

Actually, having a larger thumbnail is fine. I can just add navigation pills for the other notification types. :+1:

donotos commented 4 years ago

I don't know what other notifications you are going to implement but i imagine that new chapter notifications will still be a majority. Making thoses other notification stand out with an icon or a color is important i believe or they will be hard to spot in the middle of it all.

pierobot commented 4 years ago

This is how it looks right now, any suggestions? Would adding links to the archives be a good idea? I feel like they're too close and can easily fat finger the wrong link. Screen Shot 2020-05-31 at 00 33 28

donotos commented 4 years ago

i think the same it's not necessary to add the link per archives, it's just one click away from the series link after all. I like how it look but i don't see the tick boxes necessary for the selected dismiss, did you replace them with the blue highlight on the cover?

pierobot commented 4 years ago

https://github.com/pierobot/mangapie/commit/563c8cbdb69ff38aba81e2fc1fb2b8f849452ce1

If you want to mail notifications, then set APP_MAIL_NOTIFICATIONS to true in your .env file. Regardless if you want mail notifications or not, you will need to
run php artisan config:cache and php artisan mangapie:init. Also restart your queue workers and watchers.

donotos commented 4 years ago

Just updated and it looks great.

Can you add that too?

83345278-d6488780-a2d6-11ea-8cf5-972042cb2288

that was what i imagined in the first place.

also, you should add the "set APP_MAIL_NOTIFICATIONS to true in your .env file." in the wiki.

kurim commented 4 years ago

Since this "APP_MAIL_NOTIFICATION" enable it global, it should be a per user option to change it.