search

pierobot / mangapie

This is a self-hosted server for archived manga.
BSD 3-Clause "New" or "Revised" License
63 stars 9 forks source link

Ugly Webtoon Thumbs #165

Open donotos opened 4 years ago

donotos commented 4 years ago

Like that:

Capture d’écran 2020-05-05 à 16 39 16
pierobot commented 4 years ago

This doesn't really address the issue for now, but should I just make a new page next to the Files and Comments pills for the covers so that the chapters list does not have the covers?

image

donotos commented 4 years ago

i think the best way to fix this issue is by cropping the thumbs to a fixed WxH ratio so that every thumb has the same display size.

As for a workaround since you are making new view for #148 why not add a view like that:

81031928-ad59e180-8e53-11ea-98a3-fee0b27cad79

pierobot commented 4 years ago

You can't have a fixed width and height because then the covers will end up stretched as not all the images will be the same resolution. It has to either be proportional to the width or height.

The solution in this case is to crop the image to a ratio starting from the top left or right. I don't know what ratio to use yet. I'll have to research that at some point. It should suffice to get the ratio from the most common trim size for manga, which I think is A4. I think with manwha this might lead to some art getting cut. :man_shrugging:

donotos commented 4 years ago

Yes, i wasn't clear enough in my explanation. it's the display size that should be always the same to look nice and ordered, and YES! never do "stretching", it's ugly and i hate that!

i think A4 is the way to go it's the most common and will be satisfying with nearly everything including webtoon, even if we have only 1/10 of the image showing this will at least preview the first panel wich is good enough.

btw, i just updated and everything's ok, i like the new "list" view for chapters