pierobot / mangapie

This is a self-hosted server for archived manga.
BSD 3-Clause "New" or "Revised" License
63 stars 9 forks source link

Allow users to ignore libraries #182

Open donotos opened 4 years ago

donotos commented 4 years ago

Hey

Thanks for having made that so quickly!

So it filter library per library witch is useful as is but it is not what i expected. first, it does not restrict the search wich return results on all library. second, you cant filter more than one library. I wanted to be able to create a custom filter that you can name and, for exemple, make it show library 1 and 2 and not 3 and 4, then create another profile that will show library 3 and 4 and hide 1 and 2.

Thanks!

pierobot commented 4 years ago

The quick search is just that. It's not meant to have any filters. That's what the advanced search is for. Do you want filters in the quick search?

Screen Shot 2020-05-15 at 12 13 06

donotos commented 4 years ago

given that i want to isolate completely some library maybe we should take some time to talk about it. i'm not sure that the filter thing will achieve what i'd like to do, and maybe the work you will have to invest in it isn't worth it...

so basically i'd like to have a way to completely remove acces to some of the configured library with my user (wich is an admin) so that their content does not show in any way on mangapie. that's why i talked about some sort of profiles, it would be the ideal solution because you could switch between them quickly without login out.

pierobot commented 4 years ago

So you need to have an admin account that cannot access all the libraries, correct? What permissions do you need from the admin account?

donotos commented 4 years ago

yes that's it. i believe that a simple way to do that is by removing any access to the libraries for the administrator role and you would need to add a second role to your user to access them. or create a copy without library access of the administrator role. you could then remove the administrator role add the admin2 role to keep the admin console and a second role for library access. (not sure if i'm clear here)

pierobot commented 4 years ago

Okay, so my idea is just to migrate the current admin account to a super administrator role and overwrite the old administrator role so that it can access the admin panel but not interact with libraries they do not have permission to access from the super administrator.

That's what you're asking for, right?

donotos commented 4 years ago

Actually no. it's more simple than that,

if you want to keep an superadmin role that have access to everything at all time it's fine, but an admin role can grant access of anything to anyone including himself. so even if it remove access to some features to himself, it's not an issue since it can grant back thoses rights to himself if needed.

Basicaly i'm fine with your proposal about the superadmin, but not with the need for admin to rely on superadmin for granting himself some rights, it should be able to do it himself.

that being said that's just how i see things, and if you do as you proposed it will be good enough, as long as superadmin can give admin every right he has (if i tick all the options, admin should basically be a second superadmin)

pierobot commented 4 years ago

Okay, in this case I think it's just better to add a feature to ignore libraries in the user settings. Is that good for you? From my perspective it seems like you just want to filter libraries rather than access everything in the admin panel.

donotos commented 4 years ago

exactly. i need the admin pannel to wipe cache folders and launch a manual scan of a library most of the time. an option in user panel to filter out some library is a good approach to do what i want. i'm fine with it.

pierobot commented 4 years ago

Okay. Let's keep this issue for a user setting to ignore libraries. Permissions in https://github.com/pierobot/mangapie/issues/192