pierobot / mangapie

This is a self-hosted server for archived manga.
BSD 3-Clause "New" or "Revised" License
63 stars 9 forks source link

File view (desktop/mobile) #183

Closed kurim closed 4 years ago

kurim commented 4 years ago

Move design discussion from https://github.com/pierobot/mangapie/issues/177 to this issue.

How it is: image

How it could be: image

Desktop, FHD, Chromium

Mobile: How it is: image

How it could be: image

donotos commented 4 years ago

i believe that the preview link should not be just bellow the chapter link, after all we are on mobile view and the precision of the click with our finger is at best approximative.

kurim commented 4 years ago

I see your point. how about this: image (icon is a example not sure what to use for preview)

donotos commented 4 years ago

i think the icon is a good idea. it doesn't take much more space and do the work.

kurim commented 4 years ago

In this case we need some CSS tweaking... "width:100%" > need to removed for mobile

like this:

@media (max-width:576px){.col,.col-1,.col-10,.col-11,.col-12,.col-2,.col-3,.col-4,.col-5,.col-6,.col-7,.col-8,.col-9,.col-auto,.col-lg,.col-lg-1,.col-lg-10,.col-lg-11,.col-lg-12,.col-lg-2,.col-lg-3,.col-lg-4,.col-lg-5,.col-lg-6,.col-lg-7,.col-lg-8,.col-lg-9,.col-lg-auto,.col-md,.col-md-1,.col-md-10,.col-md-11,.col-md-12,.col-md-2,.col-md-3,.col-md-4,.col-md-5,.col-md-6,.col-md-7,.col-md-8,.col-md-9,.col-md-auto,.col-sm,.col-sm-1,.col-sm-10,.col-sm-11,.col-sm-12,.col-sm-2,.col-sm-3,.col-sm-4,.col-sm-5,.col-sm-6,.col-sm-7,.col-sm-8,.col-sm-9,.col-sm-auto,.col-xl,.col-xl-1,.col-xl-10,.col-xl-11,.col-xl-12,.col-xl-2,.col-xl-3,.col-xl-4,.col-xl-5,.col-xl-6,.col-xl-7,.col-xl-8,.col-xl-9,.col-xl-auto{position:relative;padding-right:15px;padding-left:15px}}
@media (min-width:577px){.col,.col-1,.col-10,.col-11,.col-12,.col-2,.col-3,.col-4,.col-5,.col-6,.col-7,.col-8,.col-9,.col-auto,.col-lg,.col-lg-1,.col-lg-10,.col-lg-11,.col-lg-12,.col-lg-2,.col-lg-3,.col-lg-4,.col-lg-5,.col-lg-6,.col-lg-7,.col-lg-8,.col-lg-9,.col-lg-auto,.col-md,.col-md-1,.col-md-10,.col-md-11,.col-md-12,.col-md-2,.col-md-3,.col-md-4,.col-md-5,.col-md-6,.col-md-7,.col-md-8,.col-md-9,.col-md-auto,.col-sm,.col-sm-1,.col-sm-10,.col-sm-11,.col-sm-12,.col-sm-2,.col-sm-3,.col-sm-4,.col-sm-5,.col-sm-6,.col-sm-7,.col-sm-8,.col-sm-9,.col-sm-auto,.col-xl,.col-xl-1,.col-xl-10,.col-xl-11,.col-xl-12,.col-xl-2,.col-xl-3,.col-xl-4,.col-xl-5,.col-xl-6,.col-xl-7,.col-xl-8,.col-xl-9,.col-xl-auto{position:relative;width:100%;padding-right:15px;padding-left:15px}}

Also we need modify the col-3 like this:

@media (max-width:576px) {
    .col-3 {
        flex: 0 0 25%;
        max-width: 25%;
        width: 25%
    }
}

To force with of last read & add time

Result will be: image

pierobot commented 4 years ago

I'm not too keen on overriding the css rules for just this.

What about just reducing some padding on the last read and added columns and shortening the text? Screen Shot 2020-05-15 at 13 20 57

kurim commented 4 years ago

This looks fine to me

pierobot commented 4 years ago

https://github.com/pierobot/mangapie/commit/2a6a6dfb0936721bf06bdc5f3ff3609041142dc6

kurim commented 4 years ago

it is not working

image

Also desktop view looks pretty broken.

image

The .col- width: 100%; break it there is to many unused space on wider screen than mobil if i disable it in browser preview it looks fine, that's why I thought abount the css way.

pierobot commented 4 years ago

Yea it's borked on Chromium. >_> Guess I should have checked.

kurim commented 4 years ago

It’s also broken on iOS

image

What did you use for testing?

pierobot commented 4 years ago

Firefox ESR. Managed to find a solution. https://github.com/pierobot/mangapie/commit/6e03f6bba658e647f6c4fb1354fe90dd59f3ea4b

kurim commented 4 years ago

Way better now, image image

One thing is it intended that chapter name is centered?

donotos commented 4 years ago

seems to be a browser problem. it is not centered in vivaldi, brave and firefox, but it is on safari.

kurim commented 4 years ago

Since iOS restrictions every browser used the WebKit engine so for my mobile devices it’s like this

pierobot commented 4 years ago

https://github.com/pierobot/mangapie/commit/092aa73c251cb35a461f5d5783f05349f45fbf1b should fix it.

donotos commented 4 years ago

there is no issue anymore on my side with safari.

kurim commented 4 years ago

Yeah look good image