Show notification count in navbar

pierobot / mangapie

This is a self-hosted server for archived manga.

BSD 3-Clause "New" or "Revised" License

65 stars 9 forks source link

Show notification count in navbar #212

Closed pierobot closed 4 years ago

pierobot commented 4 years ago

Can you add that too?

83345278-d6488780-a2d6-11ea-8cf5-972042cb2288

that was what i imagined in the first place.

Originally posted by @donotos in https://github.com/pierobot/mangapie/issues/152#issuecomment-638048080

kurim commented 4 years ago

How about this:

small modification on notifications.blade.php

@if ($notifications->count() > 0)
<span class="badge badge-pill badge-warning" style="position: absolute; top: 5px; font-size: 50%; margin-left: 3px;">{{ $archiveNotificationCount }}</span>
@endif

style should moved to CSS file.

pierobot commented 4 years ago

Looks like you made those changes to your own fork.

I'll merge if you make a PR excluding the changes to database.php and UserController.php as I will need to write tests for https://github.com/pierobot/mangapie/issues/226

kurim commented 4 years ago

Sure I also want to restart the fork, cause there are some issues with upgrade to laraval 6 since the doctrine/inflector does not work in the specific way anymore so an upgrade from 5.x->6->7->8 requieres more changes like i thought.

PR: is issued https://github.com/pierobot/mangapie/pull/227

pierobot commented 4 years ago

Merged