pieroproietti / penguins-eggs

On the road of Remastersys, Refracta, Systemback and father Knoppix!
https://penguins-eggs.net
374 stars 41 forks source link

cryptdevice parameter is not dropped on new install #350

Open code8buster opened 4 months ago

code8buster commented 4 months ago

cryptdevice parameter is not dropped when doing a "standard" type installation

egg was produced from an encrypted-root Arch Linux, so it's just carrying the parameter over. It was necessary for mkinitcpio to boot properly on that machine, but no longer.

The new root is still found via UUID, it's just odd that grub kept this parameter

pieroproietti commented 4 months ago

Hi @code8buster

I'm just working on syncto and syncfrom on the branch syncto.

I rewrote completely syncto, but again don't solve same problens:

Actually I will give up, for two days, but want to implement the new version, before I forgot that I did.

pieroproietti commented 4 months ago

OK,

cryptdevice parameter is not dropped when doing a "standard" type installation

egg was produced from an encrypted-root Arch Linux, so it's just carrying the parameter over. It was necessary for mkinitcpio to boot properly on that machine, but no longer.

The new root is still found via UUID, it's just odd that grub kept this parameter

That's the way to remove it? eggs just use the same configuration of the janitor... so, that I must to delete/add?

code8buster commented 4 months ago

Yes I imagine so. Eggs must do some replacement after the fact during the bootloader step, right? Otherwise it would be stuck with the same UUID for root from the old machine that produced the egg. Then it would never boot.

Probably in that step, do a check if installation type != fullencrypt and if yes, drop cryptdevice from the configuration.