search

pierotofy / OpenSplat

Production-grade 3D gaussian splatting with CPU/GPU support for Windows, Mac and Linux 🚀
https://antimatter15.com/splat/?url=https://splat.uav4geo.com/banana.splat
GNU Affero General Public License v3.0
924 stars 87 forks source link

Add Docker build #30

Closed pfxuan closed 8 months ago

pfxuan commented 8 months ago

This PR reuses the existing ubuntu CI build logic to build local or remote docker images across different setup.

pierotofy commented 8 months ago

Nice!! Love the fact that there's variables to control the lib/ubuntu version. Thanks for the PR @pfxuan !

pfxuan commented 8 months ago

@pierotofy Thank you for your help and support. Looking forward to see the next move for ODM + OpenSplat.

parkerlreed commented 8 months ago

I tried the ROCm dockerfile through podman and while seemingly creating the image successfully after setting up all the deps, it doesn't seem to compile the final binary.

The README doesn't really say anything after running the setup of how to run through Docker.

Is there anything special for that?

EDIT: Gist https://gist.github.com/parkerlreed/f123f824bd436c2989b1d00a04c12ed5

pierotofy commented 8 months ago

I think the Dockerfile.rocm file is missing the build commands (everything else should be there though).

https://github.com/pierotofy/OpenSplat/blob/main/Dockerfile#L46

vs.

https://github.com/pierotofy/OpenSplat/blob/main/Dockerfile.rocm#L70

@pfxuan might have more insights.

pfxuan commented 8 months ago

Good catch. Dockerfile.rocm includes the full version of ROCm/HIP build environment but is missing the actual compile and build part. It should be very similar to this step. I'll probably add it from the next PR with an extra ROCm 6.0.2 support: