search

pierotofy / OpenSplat

Production-grade 3D gaussian splatting with CPU/GPU support for Windows, Mac and Linux 🚀
https://antimatter15.com/splat/?url=https://splat.uav4geo.com/banana.splat
GNU Affero General Public License v3.0
924 stars 87 forks source link

Added SimpleRadial camera model to colmap.cpp #73

Closed Jonathan-Gore closed 7 months ago

Jonathan-Gore commented 7 months ago

Added the SimpleRadial camera model to colmap.cpp from https://github.com/colmap/colmap/blob/0ea2d5ceee1360bba427b2ef61f1351e59a46f91/src/colmap/sensor/models.h#L235

Copied syntax found in SimplePinhole, copying fy=fx for the models with only one focal length parameter, like SimpleRadial.

I'm new to c++ so I'm not 100% sure how to test the code.

pierotofy commented 7 months ago

Thanks for the PR @Jonathan-Gore ! See the "Build" section from the README to compile and test the changes.

Jonathan-Gore commented 7 months ago

On it

Jonathan-Gore commented 7 months ago

Updated k -> k1 and successfully built the application!

Ran the newly built .exe on the banana dataset with both PINHOLE and SIMPLE_RADIAL camera models and both were successful! simple_radial_splat.zip

pierotofy commented 7 months ago

Fantastic, thanks for testing and the useful addition! 🙏