search

pierotofy / OpenSplat

Production-grade 3D gaussian splatting with CPU/GPU support for Windows, Mac and Linux 🚀
https://antimatter15.com/splat/?url=https://splat.uav4geo.com/banana.splat
GNU Affero General Public License v3.0
933 stars 87 forks source link

Hard-coded OS version in .github/workflows/cuda/Linux.sh #86

Closed morsingher closed 6 months ago

morsingher commented 7 months ago

Hi, note that the Ubuntu version passed as --build-arg in the Dockerfile is not propagated to .github/workflows/cuda/Linux.sh:

https://github.com/pierotofy/OpenSplat/blob/4d70016baae090f119eb346d9f9b35d62bb90597/.github/workflows/cuda/Linux.sh#L12

I'm not sure that this is a bug, but surely it would be nice to be consistent. Also, at least for Ubuntu 18.04 and CUDA 11.3, cuDNN is not installed and libtorch fails to build later. Again, I'm not sure that these two things are related. Will update if I have news.

Thanks for your work anyway :)

pfxuan commented 7 months ago

Ubuntu 18.04 has reached its end of life, making it challenging to install compatible CUDA and dependency versions. As you suggested, I removed the hard-coded OS version and also enabled Ubuntu 20.04 based docker build via PR https://github.com/pierotofy/OpenSplat/pull/87. Wish this change could provide some help for your current setup.

Thank you for your feedback!