pierotofy / OpenSplat

Production-grade 3D gaussian splatting with CPU/GPU support for Windows, Mac and Linux 🚀
https://antimatter15.com/splat/?url=https://splat.uav4geo.com/banana.splat
GNU Affero General Public License v3.0
924 stars 87 forks source link

SH forward calculation for CPU #88

Closed gthev closed 6 months ago

gthev commented 6 months ago

Hi ! I'm sorry for opening this, it's probably just something I don't understand In file rasterizer/gsplat-cpu/gsplat_cpu.cpp, in compute_sh_forward_tensor_cpu, I don't understand understand why coefficients corresponding to l=1 (and sh coefficients SH_C1) are not used and filled (line 442 in current project version). If this is a mistake, I can open a PR, otherwise sorry for the issue. Thanks for this project and for your time !