New Microsoft Edge Rendering Engine

[joealbertvp]

Hi, i would start saying this is a great project!. secondly as the user agent suggests from microsoft Edge the rendering engine is not the same as Trident, but the library stills say is "Trident", i think it would be best if it says "Edge".

User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36 Edge/12.0

[pieroxy]

Edge may be a different rendering engine, but it is the clear continuation of Trident. That said, I need to make the difference, and this will be the opportunity to also differentiate Blink vs WebKit - although it will be much harder to be accurate since the UA didn't change in the process.

In short, I will get to it shortly.

[pieroxy]

I'll try to integrate this in the next release (a week from now)

[mrDoctorWho]

Sorry for doubling the message, but... any progerss on this?

[hth]

Awesome project but looks dead to me.

[mrDoctorWho]

It seems to be the best of what I could find. That is weird, actually, since java is widely used, but (almost) all projects that provide user agent parsing are dead.

[pieroxy]

Allright, I got sloppy. I'm going to resume updates. Give me a few days. That said, is there a reason Edge should be considered widely different from Trident? It looks like an incremental upgrade to me even if there was a steeper increment this time around.

[mrDoctorWho]

Yay, sounds great.

I think Edge should be considered different, because IE caused a lot of problems to the web devs and Edge doesn't seem to be that bad.

[pieroxy]

IMO, IE10/11 was already ahead of Chrome and Firefox in many areas when it got out. They stopped being an annoyance already. Edge is just a commercial name not tied at all to a fundamental change in technology. Hence my reluctance to move too fast in that direction. I'll think about it.

[pieroxy]

So, this work is underway and I was wondering how much you value non-breaking changes. I am planning on making the Browser.renderingEngine from a String to a RenderingEngine object (a new incoming class conveying more structured information). Would you rather have me add another field (something like Browser.renderingEngineDetails for example) hence not breaking your current implementations ?

This goes against performance and design, but I perfectly understand if it would be an issue on your side.

If you are OK with breaking changes I'll also try to move from fields to getters/setters (deprecating the usage of fields and making them private in a further down release) so that I will have more flexibility in doing this kind of updates without breaking anything next time.

[mrDoctorWho]

@pieroxy honestly, I'm all for getters. I don't like the current design with accessing fields that should be private.

Breaking changes are fine, as long as the documentation follows up with them.

[hth]

@pieroxy No problem. +1. Follow with documentation please.

[pieroxy]

Allright, work in progress. There is quite a bit of stuff to be done so I expect something to land by the end of next week.

[pieroxy]

I pushed the first commit do differentiate Trident from Edge. It is breaking API and there are more to come so I'd suggest to wait for the release, so you get all the breaking changes in one shot. Also I will introduce Blink vs WebKit (It is already in the enum)

[mrDoctorWho]

That is great!

Hope to check on it soon.

[pieroxy]

Ok, so I'm pretty much done with this. Still so much things to add... But:

1. Edge and Trident are now different
2. Blink and WebKit are now different
3. No more internal fields exposed, everything is done through getters (except internally but still)

How does it look to you? I plan on releasing it shortly. Your input is appreciated.

[mrDoctorWho]

Edge and Trident are now different Blink and WebKit are now different

Well, yeah. That what I was talking about. Hope we are talking about rendering engines and browsers based on this engines will be considered a one browser (for example, older Chrome was based on Webkit).

No more internal fields exposed, everything is done through getters (except internally but still)

The more OOP style, the better.

[pieroxy]

Hope we are talking about rendering engines and browsers based on this engines will be considered a one browser

Chrome 26 and Chrome 29 are both Chrome browsers. However Chrome 26 had WebKit as a renderingEngine while Chrome 29 has Blink. Same goes for IE.

[pieroxy]

Done. Let me know if you would alike anything else in this area. Glad to have feedback.

[hth]

Appreciate. Thanks for new release !!!!

[mothmonsterman]

@pieroxy thank you very much for all the recent updates! what is the correct way to determine if Chrome or Edge is in use regardless of device? BrowserFamily.CHROME seems obvious but does not report correctly for iOS Chrome on an iPhone or iPad, Also, I still do not see a BrowserFamily.EDGE. Does it require checking multiple fields?

[pieroxy]

Hmmm. That's a good point. I should create a Chrome on iOS.

For Edge you should check the RenderingEngine family EDGE object. For Chrome you can check the RenderingEngine being of type BLINK. But Chrome on iOS is falsely reported as iOS's stock browser in a WebView, which it is actually.

[mothmonsterman]

@pieroxy Cool, thanks. Need another issue for creating a Chrome on iOS?

[pieroxy]

Good thinking.

https://github.com/pieroxy/java-user-agent-detection/issues/17