search

pieroxy / java-user-agent-detection

Some code to deduce an OS/Platform/Browser out of a user-agent string
53 stars 12 forks source link

Switch ant to maven #10

Closed mrDoctorWho closed 7 years ago

mrDoctorWho commented 7 years ago

Maven has different project structure, so I changed it as well.

I'm not familiar with ant, but from what I've seen I suppose it's not really easy to keep both build systems at the one time, so I dropped ant and hope that's okay.

pieroxy commented 7 years ago

Thanks. I'll have a look this WE.

pieroxy commented 7 years ago

So, a few questions and remarks:

  1. First of all thanks for the pull request
  2. I will not merge this as it is because I have a small refactoring going on (and this code is generated). But this tells me the exact changes I have to make, so it is great.
  3. I expect to have this done next week or at worst the week after that.
pieroxy commented 7 years ago

Allright, so I pushed a commit that supposedly cover this pull request. Can you give it a try and let me know if all is covered?

If so, I'll close this one.

Thanks for the help.

mrDoctorWho commented 7 years ago

@pieroxy sorry for a long silence, wasn't able to test it before.

So, I tested it, works like a charm. But maybe you should consider doing auto-versioning? Maven supports that.

pieroxy commented 7 years ago

Yes, I'm in the process of adding the project to maven central, so all build stuff will be refactored in the coming days.

Do you have an example of a GitHub project that does auto-versioning so I can have a look?

mrDoctorWho commented 7 years ago

@pieroxy unfortunately, I don't have an example, but I think you should start here: http://maven.apache.org/maven-release/maven-release-plugin/

pieroxy commented 7 years ago

Thanks. I will.