search

pieroxy / java-user-agent-detection

Some code to deduce an OS/Platform/Browser out of a user-agent string
53 stars 12 forks source link

The code is generated #11

Open mrDoctorWho opened 7 years ago

mrDoctorWho commented 7 years ago

Hi,

I've read the README and it says:

I will not merge pull requests, as most of this code and tests are generated.

Could you please provide the code that generates your code? The data would be useful too.

It's just — neither you nor me can be sure that you'll keep up with the updates and for me, this is currently a very handy library and I actually could help keeping it alive.

pieroxy commented 7 years ago

It's a pile of crap right now. It's generated mostly because my workflow to work on this is completely and utterly broken. In other words it's generated for extremely wrong reasons.

So instead of sharing the horrendousness of my current broken toolchain, I'll try to think of a way for people to contribute to it in a smooth manner.

mrDoctorWho commented 7 years ago

@pieroxy that would be really great.

pieroxy commented 7 years ago

In the meantime I'll be glad to accept issues with User Agents in them and the proper detection proposed, but I agree it will not scale much.

mrDoctorWho commented 7 years ago

Any progress on this?

pieroxy commented 7 years ago

Going forward, yes. I am resuming work on this project, so I have a few things to dust off first :-)

mrDoctorWho commented 7 years ago

Good to know. Keep doing a great stuff.

pieroxy commented 7 years ago

The idea I currently have is to provide a page where you can choose all fields for a user agent. This will be submitted and I will be able to review it and integrate it in the lib.

Would something like that work for you ?

mrDoctorWho commented 7 years ago

To be honest, I don't see how this gonna help other developers fixing bugs in the library. You won't always be able to do that: you can be really busy, you can just get tired of this project and so on.

It can work as a temporary solution. But people say, there's nothing more permanent than temporary. I'm afraid, if you keep it for now, it'll be kept forever.