search

pieroxy / java-user-agent-detection

Some code to deduce an OS/Platform/Browser out of a user-agent string
53 stars 12 forks source link

"Stock Browser", but "SamsungBrowser" #13

Closed mrDoctorWho closed 7 years ago

mrDoctorWho commented 7 years ago

I personally don't consider this a correct way to represent the browser's name. The format for all names should be identical. If you use spaces in one name, you should use it in another.

pieroxy commented 7 years ago

Interesting point. I'll try to make a pass of cleaning. For the record, do you have any preference ?

mrDoctorWho commented 7 years ago

Stock, Samsung, etc.

I mean, maybe there shouldn't be a Browser in the name? This is a browser name. If someone wanted, they would add "Browser" in the name by themselves in an upper level.

Same for BrowserFamily.

pieroxy commented 7 years ago

Makes perfect sense :)

These are leftovers of an era in which the results were just a bunch of strings without a proper structure.

pieroxy commented 7 years ago

Fixed in the latest commit. Thanks for the feedback.