search

pieroxy / lz-string

LZ-based compression algorithm for JavaScript
MIT License
4.12k stars 568 forks source link

Issues and v2 work updates #189

Open karnthis opened 9 months ago

karnthis commented 9 months ago

Work to reduce outstanding issues new and old. Impacted items include:

List to be updated as work is completed.

karnthis commented 9 months ago

@Rycochet your thoughts, if you would please.

Rycochet commented 9 months ago

Almost there I think :-D

karnthis commented 8 months ago

I have everything done except the tests. since you redid the library I am having issues as my tests no longer work but the code being tested did not change. @Rycochet can you go into details on your process for setting up the base64 tests, since that is very similar to what the new tests need?

Rycochet commented 8 months ago

@karnthis The biggest thing is that the tests will fail when there is a fix to the underlying code - they're comparing against a "known good" binary output, but in reality the fix means that's not correct any more - you should be able to delete the files for the two fixed encoders, and re-run the test.sh script with the -u option to update those files - which will then be used by the actual vitest tests - do feel free to update things and push with those tests still failing if it's not clear (and then I can checkout locally and give any other pointers that might be needed) :-)

Rycochet commented 8 months ago

(Note that once this is merged I want to add specific handling for the legacy versions into the test scripts - but not entirely sure what form that needs to take!)

karnthis commented 5 months ago

considering the significant number of changes that have happened to the master branch since this started I am considering scrapping what is here and starting fresh. The work still needs to be done but it will need to be approached differently now that things have stabilized a bit.

@Beeloo0011 what?

wkrick commented 5 months ago

Beeloo0011 what?

@karnthis

I think this is a bot. Their GitHub history is really bizarre. Like they're probing for insecure repos or something.

karnthis commented 5 months ago

yeah that was my assessment too, was curious to see if I would get a response. didn't expect someone else to reply lol.

karnthis commented 2 weeks ago

@Rycochet