pierpo / react-archer

🏹 Draw arrows between React elements 🖋
https://pierpo.github.io/react-archer/
MIT License
1.17k stars 68 forks source link

Migrate to Typescript #165

Closed pierpo closed 2 years ago

pierpo commented 2 years ago

I just migrated the whole codebase to Typescript.

Benefits

Drawbacks

TODO

pierpo commented 2 years ago

Everything works! :rocket:

ThiloAschebrock commented 2 years ago

@pierpo Would you mind releasing a new version that includes these changes? With @types/react for React 18 children are no longer automatically included, which causes issue with react-archer. However, this PR already includes the necessary adjustments to work with the updated react types.

pierpo commented 2 years ago

Sure, will do!

pierpo commented 2 years ago

Done. Thanks for asking for it. I was procrastinating :smile: (and also wondering "major or minor?" but since there's been a drop in flow support, it can be considered a major upgrade)

ThiloAschebrock commented 2 years ago

Thank you! @pierpo