pierr3 / TrackAudio

A next generation Audio-For-VATSIM ATC Client for macOS, Linux and Windows
Other
47 stars 11 forks source link

HF - Display VHF alias frequency #199

Open Adrian2k opened 5 days ago

Adrian2k commented 5 days ago

So in AFV you can see what VHF frequency is aliased to your HF frequency - this does not seem to be a feature in trackaudio image

Adrian2k commented 5 days ago

Same issue in beta3 image

GeorgeBarlow commented 5 days ago

This is currently not a supported feature, we'd need to look into expanding our implementation of interfacing with the VATSIM audio network before providing this feature.

@pierr3 this would require some sort of change to APISession on afv-native to access the frequencyAlias key on the incoming json from the AFV api as it currently passes through only a string containing the name of the station and an unsigned int containing the frequency from the frequency element on the json. Probably would be worth while just defining a struct and replacing the int with that when returning the std::pair.

pierr3 commented 5 days ago

Iā€™m not sure the API actually returns the frequency at all for aliases, think we have to match by station name but will check

On Sun, Nov 3, 2024 at 00:04 George Barlow @.***> wrote:

This is currently not a supported feature, we'd need to look into expanding our implementation of interfacing with the VATSIM audio network before providing this feature.

@pierr3 https://github.com/pierr3 this would require some sort of change to APISession on afv-native to access the frequencyAlias key on the incoming json from the AFV api as it currently passes through only a string containing the name of the station and an unsigned int containing the frequency from the frequency element on the json. Probably would be worth while just defining a struct and replacing the int with that when returning the std::pair.

ā€” Reply to this email directly, view it on GitHub https://github.com/pierr3/TrackAudio/issues/199#issuecomment-2453218764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN7UK2QMAQ2OOYUA53PWGLZ6VLBNAVCNFSM6AAAAABRCAOZCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGIYTQNZWGQ . You are receiving this because you were mentioned.Message ID: @.***>

GeorgeBarlow commented 3 days ago

preview

WIP subject to change: showcasing an idea that I've been playing around with. Hover the frequency to find the alias, or click the alias to flip the persisted frequency around (between HF or VHF), marks paired frequencies with the VHF/HF icon in the top left hand corner of the radio box

neilenns commented 3 days ago

Looks so good šŸ˜

pierr3 commented 3 days ago

Looking great, would suggest it defaults back to HF frequency on leaving the hover zone but otherwise good solution

GeorgeBarlow commented 3 days ago

Looking great, would suggest it defaults back to HF frequency on leaving the hover zone but otherwise good solution

It does by default show the HF and only on hover the VHF, but the user can click it to switch it around if they desire.