search

pierr3 / TrackAudio

A next generation Audio-For-VATSIM ATC Client for macOS, Linux and Windows
Other
49 stars 11 forks source link

Don't include backend in package-lock.json #205

Closed neilenns closed 2 weeks ago

neilenns commented 2 weeks ago

Fixes #204

pierr3 commented 2 weeks ago

Package lock must be committed to ensure dependency reproducibility between builds. It is not good practice to ignore it.

neilenns commented 2 weeks ago

The backend is installed fresh on every build so there is no dependency verification required. Both locally and in the ci/release builds we have to run npm run build:backend to get it built and installed. If it were a published npm package then dependency verification would make sense, but here it's just some files that have to be in the node_modules folder.

I tested this locally by deleting my node_modules folder then doing the normal build steps:

npm run build:backend
npm run build:win

And that correctly puts trackaudio-afv into the node_modules folder:

image

and produced a TrackAudio installer with a build that runs.

neilenns commented 5 days ago

I just hit this again @pierr3. Can you please reconsider this PR? 🙏