search

pierr3 / VectorAudio

An Audio-For-VATSIM ATC Client for macOS, Linux and Windows
GNU General Public License v3.0
48 stars 11 forks source link

Unable to connect to position (AFV API Issue?) #5

Closed dechilders closed 2 years ago

dechilders commented 2 years ago

Hi Pierre,

I've got VectorAudio installed and configured, and I'm connected to the network (through VRC). When I try to connect VectorAudio, the callsign I'm connected as does not auto-add as it should (at least from what I understand). When I try to manually add it, it doesn't do anything. The afv.log file shows a couple of errors related to the API.

Log File

pierr3 commented 2 years ago

I suspect this is something I didn't foresee, the search API in AFV might not actually be public, my CID has extra permissions which means it works. Let me investigate this.

dechilders commented 2 years ago

I double checked the credentials and everything seems fine, it shows my callsign in the top left before I even connect, so I'm assuming that means the credentials are for sure right. I'm able to connect and add other positions in my ARTCC, but when I try to add mine nothing happens.

Will wait to see what you find on the search API, thanks!

pierr3 commented 2 years ago

Ah so you can add other positions aside from the one you are connected as? Could you share which callsign you're trying to add? Can you check you're running the latest version/commit?

jonaseberle commented 2 years ago

I think @dechilders you expected that your logged in station is auto-added.

That is not the case and I haven't expected VECTOR to do that yet.

After connecting I am adding my station (or ones I want to monitor) and they get added then. image

dechilders commented 2 years ago

I can add other callsigns, but not my own. The only callsign I have tested it with so far is SDF_GND. I tried entering stuff like IND_GND and IND_CTR and both populate correctly like I would expect them to, but nothing for SDF_GND.

I'm running the latest version (0.2.0), I was actually watching the GitHub action waiting on it to finish so I could grab the latest artifact it produced. I tested an earlier build (before the 0.2.0 produced last night), by pulling the source and compiling it myself, but it had the same results.

pierr3 commented 2 years ago

Haha I really need to put some caching on those github actions, sorry about how crazy long it takes.

I've just done a search in the AFV database, and it seems like SDF_GND does not exist, this might be an issue for your FE to add. Currently VectorAudio assumes all frequencies are in the database, if you try to add a frequency which is not defined in AFV, it won't add it. I need to add an airport database, so that in these situations VectorAudio can create an ad-hoc frequency.

To recap, IND_GND is in the AFV database, SDF_GND is not, which is why you cannot add it. Can you ask your FE to define it?

pierr3 commented 2 years ago

I think @dechilders you expected that your logged in station is auto-added.

That is not the case and I haven't expected VECTOR to do that yet.

After connecting I am adding my station (or ones I want to monitor) and they get added then. image

The auto-add feature has been added in v0.2.0 :)

dechilders commented 2 years ago

To recap, IND_GND is in the AFV database, SDF_GND is not, which is why you cannot add it. Can you ask your FE to define it?

Ahh that makes sense. I will get with the staff at my ARTCC and see if they can add it. We don't currently have a FE, but I'm sure someone can get it done. Thanks for looking into it!

pierr3 commented 2 years ago

If someone from your ARTCC shoots me a discord DM or email, I can also add it if you have no one currently managing this :)

dechilders commented 2 years ago

Apparently anything TWR down is not added to the AFV database by design and they won't be adding it, thanks for the help though Pierre!

pierr3 commented 2 years ago

Thanks for letting me know! This is actually quite important, because it's a different behaviour to the classic AFV client that I need to implement. I'll add the same feature means I need to add an airport AFV and automatically create the frequency

jonaseberle commented 2 years ago

The auto-add feature has been added in v0.2.0 :)

Is that meant to work like that?

In that case that has not worked for me either with VECTIR v2.0 with EDDS_N_APP. When manually adding it, that station and all below (DEL, GND, TWR and secondary APP frequencies) show up.

pierr3 commented 2 years ago

I've checked and indeed it should be working, but as suspected I am using a restrict AFV API call. I've asked the AFV dev to open up the API and it should fix it