search

pierr3 / VectorAudio

An Audio-For-VATSIM ATC Client for macOS, Linux and Windows
GNU General Public License v3.0
48 stars 11 forks source link

Feature Request: API for frequency inquiry #52

Closed KingfuChan closed 1 year ago

KingfuChan commented 1 year ago

Would like to know is there any possibility to build an API which returns the current RX and TX channels and frequencies?

E.g. -> "/RX" and "/TX", returns "xxxx_CTR:120.300,xxxx_APP:122.250,xxxx_TWR:118.375"

I'm considering building another plugin to do the work of AndyTWF/afv-euroscope-bridge.

pierr3 commented 1 year ago

Done! In the same format as you gave except lowercase for the urls (/tx and /rx). It will be available in the next release

KingfuChan commented 1 year ago

Wow! That's quick. Though I'm still doubting whether to add this feature to a new plugin or just into my RDF. Is there any potential delays when multiple requests are sent at the same time?

pierr3 commented 1 year ago

Yes, but only if you rapidly spam the API, there should be 16 workers available to handle 16 simultaneous calls, but be gentle!

If you integrate it into the RDF plugin, I would be more than happy should you wish to package the plugin DLL with the application. Thank you for your work!

jonaseberle commented 1 year ago

Thank you both for working on that!

It would be great if these changes could be made as a pull request to the original plugins so that they would ultimately support support AfV + VectorAudio.

That way the packages that ARTCCs provide to their users could support both without the users having to change the plugins.

KingfuChan commented 1 year ago

It would be great if these changes could be made as a pull request to the original plugins so that they ultimately support would support AfV + VentorAudio.

actually my RDF does support the official AFV, but since there haven't been any activities on the original repo and I basically rewritten the plugin so I think a PR may somehow do more damage. So I just keep my RDF there. Also to be noted, many TopSky users don't need an extra RDF plugin since it's already integrated though it's not adapted to VectorAudio.

As for the bridge plugin, the original repo is also silent for 3 years. But there was some progress PR#2 by its author, which is neither being developed nor been merged to main branch. It is also a major update, which makes me doubt the propriety to start a new branch and finish it then pull it back.

pierr3 commented 1 year ago

Closing this as we should be all good, let me know if not!