Handle airport frequencies that are not defined in the database

[pierr3]

Some frequencies related to airports are not added in the AFV database by design, in this case, the client should create the frequency automatically with one transceiver set at the airport location.

Implementation suggested:

• Load in memory an airport database (see this repo)
• Add logic that if a station is not found, it needs to check if the ICAO exists in the airpot database, if it does, then it needs to create the frequency and change the client position to that airport location in afv_native
• Upon adding the frequency, AFV native will use the client position

See #5

[jonaseberle]

I suggest using https://github.com/vatsimnetwork/vatspy-data-project/blob/master/VATSpy.dat. The format is not very pretty but it's known in VATSIM and changes will be reported there by FIRs.

[pierr3]

That's a very good suggestion, but it does not seem to have airport elevation which is necessary to set the transceiver antenna at the right height

[jamieernest]

Is there a way to put in the data ourselves? Currently this doesn't support VHHH which is a bit of a bummer...

Also the database that you mentioned doesn't have historic airports such as VHHX which are still simulated in VATSIM.

[pierr3]

Best and quickest way at the moment is to add the frequencies to the AFV database, which is also how the recommend way in the Facility Engineer manual.

[jamieernest]

Hmm from what I understand if the frequency is available in AFV it should also be available here, but the weird thing with VHHK (which I am testing with) is that when I enter VHHH_S_GND, VHHH_S_TWR, VHHH_DEL, VMMC_DEL, VMMC_GND, VMMC_TWR, VHHX_DEL, VHHX_GND or VHHX_TWR nothing happens, but if I do VHHH_APP and HKG_E_CTR it works, why would that be?

[dechilders]

@jamieernest sounds like the same issue I was having that we were discussing in #5 -- anything tower down is not in the AFV database. I asked my ARTCC about this, and this was their response:

"No we do not define those because they do not need a radar site. It will place a transceiver on where you are centered."

[jamieernest]

Sorry @dechilders didn't see the closed issues, so it is a known issue. Thank you!

[pierr3]

Hmm from what I understand if the frequency is available in AFV it should also be available here, but the weird thing with VHHK (which I am testing with) is that when I enter VHHH_S_GND, VHHH_S_TWR, VHHH_DEL, VMMC_DEL, VMMC_GND, VMMC_TWR, VHHX_DEL, VHHX_GND or VHHX_TWR nothing happens, but if I do VHHH_APP and HKG_E_CTR it works, why would that be?

Your issue is linked, but indeed if these are defined in the AFV database, they would also not add due to an issue with the AFV API. I have just pushed a new temporary release which will auto add the frequency you are logged in as, it should help mitigate this.

For the stations not defined in AFV, a fix is coming.

[jamieernest]

The new release did fix the issue for me. Thank you for your extremely quick responses!

[jamieernest]

Actually, @pierr3 currently my frequency shows up, but pilots can't hear me, is there an indication somewhere that I am transmitting or not?

[jamieernest]

Also, if I delete the station and add it manually nothing happens, and if I disconnect and connect again the frequency wont be added again

[pierr3]

Actually, @pierr3 currently my frequency shows up, but pilots can't hear me, is there an indication somewhere that I am transmitting or not?

Disconnecting/Reconnecting is linked to issue #7 which needs to be fixed.

You can check if you are transmitting if "TX" goes yellow when you press your PTT. Which platform are you? macOs?

[jamieernest]

Yep, I'm on macOS and the TX doesnt go yellow for some reason

[pierr3]

Try to go to your Privacy Settings and allow VectorAudio in the "Input Monitoring" category. Somehow I have also had problems recently due to macOs blocking background key detection.

[jamieernest]

Hm nope, no dice...

[jamieernest]

Nevermind, got it working by enabling the unix executable in VectorAudio/MacOS/vector_audio, thanks for your help!

[pierr3]

Thanks for reporting, there is definitely something going on with SFML and global key presses when using the .app on macOs

[jamieernest]

No problem, and thank you so much for your lightning response times 😆

[pierr3]

A partial implementation (also know as "good enough") is now in v0.5.0!