pierr3 / vSMR

EuroScope Plugin to simulate the NOVA 9000 A-SMGCS system on VATSIM
GNU General Public License v3.0
68 stars 28 forks source link

Euroscope hangs on exit #55

Closed drose12 closed 4 years ago

drose12 commented 4 years ago

New FIR FE here, our packages had and older version of the plugin, but things worked fine. I upgraded, but now ES hangs on exit and you have to kill the task. If I nuke everything it works fine with the version I have, but as soon as I put a newer version in, it will hang. Just looking for assistance on how to troubleshoot.

Keanu73 commented 4 years ago

So this is with the current nightly build, right?

drose12 commented 4 years ago

No, i was using v1.4.0 - Consolidation update I will go try the nightly.

drose12 commented 4 years ago

Confrimed, same behaviour on nightly.

Keanu73 commented 4 years ago

Right.. I haven't experienced EuroScope hanging so you'll have to check the vSMR config is valid. Try using the one provided with the nightly build and changing it to your needs. Otherwise I'm not sure how else I can help.

drose12 commented 4 years ago

I am using the default json that comes in the zip. Is there a way I can attach a debugger to the plugin? I'd think there must be some way to issue a thread dump or something like that?

On Sun, Dec 15, 2019 at 11:37 PM Keanu C. notifications@github.com wrote:

Right.. I haven't experienced EuroScope hanging so you'll have to check the vSMR config is valid. Try using the one provided with the nightly build and changing it to your needs. Otherwise I'm not sure how else I can help.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pierr3/vSMR/issues/55?email_source=notifications&email_token=AAFZDLJKW5WMTB4UA5APOPDQY4V5LA5CNFSM4J2256F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG5ZIJQ#issuecomment-565941286, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFZDLOEIJJ67LLCHFMNMTTQY4V5LANCNFSM4J2256FQ .

-- Dave Rose drose@drcs.ca

Keanu73 commented 4 years ago

You can do that by attaching to EuroScope I believe, although it should issue a crash dump if it detects one (it's stored where the EuroScope exe is). Have you isolated the problem to be with vSMR?

drose12 commented 4 years ago

Well isolation has been done by troubleshooting. If I have the newest vsmr.dll in it hangs, if I put an older one in, it does not. So I'm pretty sure its the plugin. I'm attaching Euroscope crash files as you mentioned above.

EuroScope caused an Access Violation (0xc0000005) in module vSMR.dll at 0023:5860a597.

Exception handler called in ExceptionAttacher.cpp - AfxWinMain. Error occurred at 12/14/2019 09:03:34.

crashfiles.zip

drose12 commented 4 years ago

Tried running as Administrator as well, no difference.

Keanu73 commented 4 years ago

Right, just realised, you might have been using a weird nightly build that didn't include some previous changes - just re-download the nightly for me with the default config and see if it still has an error. Also make sure you put your ICAO_Airlines.txt from the DataFiles folder into the same folder as the vSMR dll. Otherwise, you may be missing a redistributable or something along those lines

drose12 commented 4 years ago

Question regarding ICAO_Airlines.txt, I use files generated fromhttp://gng.aero-nav.com and they generate the file, also our profile references it here: Settings airlines \CZVR\ICAO\ICAO_Airlines.txt Is it possible there is a conflict of some sort? Does your plugin respect the Settings key value in the .prf files?

Keanu73 commented 4 years ago

The plugin doesn't check the Settings key, it checks to see if ICAO_Airlines.txt is in the same folder as itself. So copy that file to where vSMR_nightly.dll is located

pierr3 commented 4 years ago

@drose12 any success using the latest nightly build? Do not forget to copy ICAO_Airlines.txt to the same folder as the vSMR dll.

CBT-Phoenix commented 4 years ago

I have just updated Euroscope to r24 beta, and found out that with vSMR enabled it hangs and crashes on exit. With r23 there wasn't any issue at all. The problem is present both with the nightly build and without

philaldred commented 4 years ago

Also having the above issue

EDIT: A cycle of the plugin seems to of fixed it.

CBT-Phoenix commented 4 years ago

Also having the above issue

EDIT: A cycle of the plugin seems to of fixed it.

What is a cycle of the plugin?

philaldred commented 4 years ago

Hey

Unload plugin>restart>load plugin>restart

On Tue, 21 Apr 2020, 22:32 Giovanni Tarar, notifications@github.com wrote:

Also having the above issue

EDIT: A cycle of the plugin seems to of fixed it.

What is a cycle of the plugin?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pierr3/vSMR/issues/55#issuecomment-617425480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGBRDYWYAUUWO72HDKQXALRNYGF5ANCNFSM4J2256FQ .

CBT-Phoenix commented 4 years ago

Already tried more than 4 times...unfortunately I had no luck :-(

philaldred commented 4 years ago

I forgot to mention, in the beta release notes of euroscope install the latest Microsoft redistributable package as it says. Then try again

On Tue, 21 Apr 2020, 22:57 Giovanni Tarar, notifications@github.com wrote:

Already tried more than 4 times...unfortunately I had no luck :-(

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pierr3/vSMR/issues/55#issuecomment-617435250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGBRDZ544F6SVA23JMXVH3RNYJF3ANCNFSM4J2256FQ .

CBT-Phoenix commented 4 years ago

Also tried with redist from ms website, but still the same issue. As soon as I have time I'll try to do a clean install of Euroscope and then add vSMR

pierr3 commented 4 years ago

I've just retargetted the nightly build to use Visual Studio 2019, same as the latest EuroScope build, can someone give it a try? I've also emailed Gergely to try and obtain a recompiled library.

CBT-Phoenix commented 4 years ago

I have just downloaded the nightly from the github main page and tried, but still no luck :-( I hope Gergely will be of some help. Thanks for the amazing plugin btw!

pierr3 commented 4 years ago

Pushed yet another update compiling with the latest .lib and .h from Gergely, could someone give it a go?

CBT-Phoenix commented 4 years ago

Just gave it a try and found something interesting: with the normal release the same issue, but with nightly it works only under certain conditions. The plugin vSMR must be 3rd in priority in the Euroscope Plug-ins settings. Also (in my case) it works only when is placed below RDF and ukcp plugins. When placed above one of them it cause Euoscope to hang on exit. But for now we can say that the issue no longer persists

kusterjs commented 4 years ago

Can you tell us all the plugins you use and it's order so we can investigate on other systems. I suspect it might also be the combination of certain plugins not compatible with each other. We need to find out which ones cause the issue.

CBT-Phoenix commented 4 years ago

For sure. I use vSMR, RDF, ukcp, and AFV Bridge. I recently added the Discord plugin but the issue existed also before so I don't think it has something to do. The order I found to be faulty is whenever vSMR is placed above RDF and/or ukcp The order I used before was: vSMR, RDF, ukcp, AFV bridge; but after the update of r24 and the just-released nightly, the order that works for me is: RDF, ukcp, vSMR, AFV bridge.

kusterjs commented 4 years ago

I have neither RDF nor ukcp. However, I use the AFV bridge as well. How about others?

CBT-Phoenix commented 4 years ago

The only common one is AFV bridge then. I use only those 4 (vSMR, ukcp, RDF and AFV bridge). I also added the Discord plugin recently, but the issue was occurring also before I added it so I would exclude it. The interesting part is that ES hangs only when vSMR is above ukcp or RDF. I can give a try without each plugin if necessary

pierr3 commented 4 years ago

Interesting find, would be good to see if just AFV Bridge + vSMR causes an issue, since I assume most people are using AFV Bridge now. I still find it strange this came up with the latest beta.

kusterjs commented 4 years ago

There seems to be something wrong with the Plugins management by ES. I did some testing and reported it in the VATSIM forum. https://forums.vatsim.net/topic/27189-moving-plug-ins-list-entries-results-in-multiple-errors-and-a-freeze-of-es-when-closing-the-application/

CBT-Phoenix commented 4 years ago

Very interesting. I basically have almost the same issues with the plugins' settings. Thank you very much for the investigations and for creating the post on vatsim forum. Hopefully they will find the cause and correct it in the next beta

DoubleWhisky commented 4 years ago

Hi. Exactly same thing is happening to me since I loaded AFV Bridge.

erikwachters commented 4 years ago

Hi, This is what I did to solve it:

All good now!

Erik

CBT-Phoenix commented 4 years ago

Already tried, but in some cases it works, in some other it doesn't. As kusterjs said previously, the problem is in neither vSMR, nor AFV Bridge, but in how Euroscope manages the plugins. Have a look at the thread he made in the Vatsim forum: https://forums.vatsim.net/topic/27189-moving-plug-ins-list-entries-results-in-multiple-errors-and-a-freeze-of-es-when-closing-the-application/

pierr3 commented 4 years ago

I may have fixed it, still strange the behaviour changed since the last beta. Could someone give it a try on the nightly as well? Works fine on my end.

CBT-Phoenix commented 4 years ago

Just tried it out with different combinations of plugins. It still hangs on exit. Also, I've noticed that when moving the plugins down, Euroscope changes their names in the Plug-Ins window. At this point, I really think that the issue is within EuroScope, and how it handles the plugins.

pierr3 commented 4 years ago

There is definetely an issue with EuroScope itself, but I do think i have some blame to take. I just attached a debugger to ES and found that the old vStrips thread, whcih i thought I had removed, was still in there waiting, can you try that nightly build?

CBT-Phoenix commented 4 years ago

Just tried it out. It works perfectly now! Thank you very much for your hard work!! :-)

pierr3 commented 4 years ago

Amazing! Great to hear. If there are no more reports, I'll publish a release, but it'd be great if others could also report the fix as working

CBT-Phoenix commented 4 years ago

Of course, given the nature of this issue, if other users will report it functional then it's safe to assume the latest nightly is working fine

CBT-Phoenix commented 4 years ago

I had a couple of fellows controllers test the new nightly, and they both reported it as functional. They had the hang issue before, but now it looks fixed! :)

quantumDavey commented 4 years ago

Hi, from my tests, the hang only happens if the (release) vSMR plugin is somwehere before the UKCP plugin in the list order - I've tested every possible ordering of the four plugins. The order of RDF and AFV plugins in the list in relation to all the others doesn't seem to affect it.

Just as with others, the nightly build deffo fixes the problem. Thanks for the fix :)

pierr3 commented 4 years ago

Fixed in v1.5