search

pierre-alain-b / rainloop-nextcloud

Rainloop plugin for Nextcloud
110 stars 37 forks source link

l10n: Change translation download #194

Closed Valdnet closed 4 years ago

Valdnet commented 4 years ago

Allows you to download the translation by Transefix.

nkinkade commented 4 years ago

@Valdnet: As we were discussing in #139, I don't believe that this file is the right place for this. Changing oData['Message'] in this file to a fixed string takes away the ability for the backend code to determine the appropriate message to display to the client. I just haven't had a free moment to make a PR to internationalize the PHP file. Could you submit a PR modifying the PHP file instead of this file?

nkinkade commented 4 years ago

This PR can be replaced/closed by this one: https://github.com/pierre-alain-b/rainloop-nextcloud/pull/197

Valdnet commented 4 years ago

I just haven't had a free moment to make a PR to internationalize the PHP file.

Nothing happened. I understand :wink:.

I close. Better solution #197