pierre-alain-b / rainloop-nextcloud

Rainloop plugin for Nextcloud
110 stars 37 forks source link

Blank Screen with NC 19.0 and Rainloop 7.0.1 #201

Closed Pecadis closed 4 years ago

Pecadis commented 4 years ago

Hi Alain,

first, i would like to thank you for your work. I am using Rainloop since Years and really appreciate your doing. I have lately upgraded to 19.0 by accident and have seen that Rainloop just started showing a blank Screen when opening the App. Do you have an idea where this could come from?

I have seen that the Browser Console is refusing to execute some scripts because the Mime Type doesn't match.

image

However, even if i disable the header "X-Content-Type-Options" in nginx, it still doesn't work. The Logs in RL itself seems to be fine and connecting to the Mailserver Properly as it should.

How can i support you to solve this issue?

Best Regards

Griefed commented 4 years ago

@waltherjj's Hack worked for me, too. Thank you very much! Running Nextcloud with a docker-compose composed of NGINX and Let's Encrypt auto-certification

Pit-Storm commented 4 years ago

I have the same problem but not able to edit such files, because using a hosted instance on hetzners storage-share. A few days ago it worked fine but since today it's only showing a blank screen.

Nextcloud 19.0.1 rainloop: 7.0.1

Is it possible that there will be a patch on appstore soon?

pierre-alain-b commented 4 years ago

Well, unfortunately for now, there is no simple hack identified (unless I missed something) that would work both for classical deploments and a custom apps path. Am I misunderstanding the situation here?

bungyguy commented 4 years ago

I have the same issue at Hetzner, cannot edit files because it is a managed instance. Running on: Nextcloud 19.0.1 rainloop: 7.0.1

I would be very good if you could adress the issue on the Nextcloud Marketplace for usage within the NC platform.

Kind regards!

bungyguy commented 4 years ago

Hi Pierre

Can you please change the compatibility in the NC Store to not compatible with NC19 then? Do you intend to release a working update or is the plugin for NC19 obsolete now?

Kind regards!

pierre-alain-b commented 4 years ago

In fact Rainloop is compatible with NC19, I have hundreds of users using it without issue. The issue only appears when one chooses to use a custom path for the apps folder. It is not yet clear for me in which situation apps are deployed this way rather than the standard way. A clue anyone? Is this the standard behavior from now on?

cvandesande commented 4 years ago

It is not yet clear for me in which situation apps are deployed this way rather than the standard way

It's pretty standard if you are using the official Nextcloud docker image: https://github.com/nextcloud/docker which I suspect most of the "managed" Nextcloud providers are using in order to automate their upgrades and rollbacks.

The custom_apps setup is describe in the README.md towards the end

Pecadis commented 4 years ago

Yes, as far as i can see, the Custom apps folder makes sense, if you want to avoid problems when updating your NC instance and separate between the Official and Custom ones.

https://docs.nextcloud.com/server/19/admin_manual/apps_management.html#using-custom-app-directories

Wouldn't it make sense to throw away the conditional if and replace the path with the variables from the Documentation? Something like this (Pseudocode)

get scriptpath // to know where rainloop is located
read the "app_paths" array and find the matching one
return the path with the appropriate url of the array.

Because with the current workaround, we are basically doing this step manually by replacing the default path "/apps/rainloop/app" with the custom one "/customapps/rainloop/app" which basically just overrides everything in the condition.

bungyguy commented 4 years ago

Hi Pierre

Can we expect a resolution for people with hosted instances who are not able to correct the code in the files directly? The original app for mail is really poor compared to yours. However, on Hetzner and likely other magaged hosters, your plugin is rendered useless right now.

Do you have any intention to fix this? Because currently it does not look like it. This is marked as a bug for two months and nothing happens?

Why is there no reply to Pecadis' message? Custom App directories are common, well documented and compatible with pretty much every plugin - except yours!

Pecadis commented 4 years ago

@bungyguy no need to be personal on him. He is doing this by himself without any payback, so be kind or do something contructive

pierre-alain-b commented 4 years ago

@pecadis and @cvandesande thank you for pointing out the context in which custom_apps are used, I understand now why the apps are placed in the custom folder. Your pseudocode makes absolute sense.

@bungyguy yes clearly your message is not helping, every minute I spend on this plugin is taken from:

If you put forward a pull request to fix this, this would be of tremendous help and I pledge to review and accept it in very little time. That would be a better way forward and smarter than your message.

bungyguy commented 4 years ago

Hi Pierre

I did not want to be rude, sorry if thats the case. I really just wanted to know if a fix is coming or if the plugin is now obsolete on some hosted environments. A solution was proposed by Pecadis and others, but no reaction.

I am not a developer, so I cannot help with a pull request. However, I am more than happy to support the project financially, so let me know your paypal address and I will do whatever I can towards the project.

Anyways, thanks a lot for your work on the application!

pierre-alain-b commented 4 years ago

I have a fix to propose. I will publish 7.0.2 on the app store and you will tell me if this works. Then maybe we will be able to cheer and close this issue.

pierre-alain-b commented 4 years ago

And @bungyguy if it works and if you want to pay me a coffee or a beer, here you can go https://paypal.me/pierrealainb

bungyguy commented 4 years ago

Hi Pierre

Thank you so much for your efford on fixing this. I can confirm everything is smooth on Hetzner NC19 and RL 7.0.2. Enjoy a few beer and coffee. ;-) Maybe you can put the paypal link on your website for others too?

Have a nice Weekend!

eloo commented 4 years ago

Looks also good with hoellen/nextcloud 👍 Beer incoming!

Thanks

Pecadis commented 4 years ago

@pierre-alain-b it works on my instance as well. That seems to have solved the issue =)

samsalway commented 4 years ago

Working in Docker 👍

pierre-alain-b commented 4 years ago

Thank you everyone for helping understand the conditions in which the bug occurred, for reporting about it and for your patience! And thanks to all who sent some support/beer/coffee/candies through Paypal, much appreciated!