search

pierre-alain-b / rainloop-nextcloud

Rainloop plugin for Nextcloud
110 stars 37 forks source link

After the update to 7.2.1 the nextcloud contacts do not appear anymore #272

Closed JordanDIG closed 2 years ago

JordanDIG commented 2 years ago

Hello, I just updated the rainloop application to v16 and the problem is that since the update the nextcloud contacts are no longer displayed in the to field when writing a mail.

CC @pierre-alain-b

JordanDIG commented 2 years ago

I am in nextcloud 23.0.3.2

pierre-alain-b commented 2 years ago

Can you clarify which contacts you are referring to? I guess you mean the nextcloud users? correct? As mentioned in #95 ?

JordanDIG commented 2 years ago

Can you tell me what the values are and in which file I should edit them? Because I don't really understand...

JordanDIG commented 2 years ago

I edited the value owncloud_suggestions = Off in the configuration files but I still can't see the contacts. @pierre-alain-b

jaycedk commented 2 years ago

I'm also having this problem. Before 7.2.1 my nextcloud contacts would show up in the to field. billede Now there is no contacts.

I have now rolled back to 7.1.3 And that version is working.

JordanDIG commented 2 years ago

The problem is that I made some changes on my server where my nextcloud is so I can't go back :/

pierre-alain-b commented 2 years ago

Well, as a temporary fix, you can always re-install the previous version https://github.com/pierre-alain-b/rainloop-nextcloud/releases/download/7.1.3/rainloop.tar.gz.

I am looking at the change in behavior - for now I cannot find what we changed in v1.15 to nextcloud suggestions work and that would have been changed in v1.16.

pierre-alain-b commented 2 years ago

Are you sure this was working in NC23 with the previous version of Rainloop v1.15 ?

jaycedk commented 2 years ago

Yes its working in NC23.0.3 billede With Rainloop 1.15.0 billede billede

scubamuc commented 2 years ago

Confirming described issue on multiple instances

scubamuc commented 2 years ago

Workaround for hosted Nextcloud 23.03 updated to Rainloop 7.2.1

worked for me...

Nextcloud-snap 23.02 updated Rainloop to 7.2.1 described issue remains

pierre-alain-b commented 2 years ago

Interesting, thank you @scubamuc - this would mean the issue is not in the code base. @jaycedk @JordanDIG can you give it a try?

jaycedk commented 2 years ago

Just tried @pierre-alain-b just tried, but that did not work for me. Rolling back again.

scubamuc commented 2 years ago

@jaycedk sorry to hear didn't work for you @pierre-alain-b may have been a lucky shot in the dark for hosted Nextcloud 23.03? Nextcloud-snap 23.02 does not budge

scubamuc commented 2 years ago

@pierre-alain-b here ist my error log on Nextcloud-Snap 23.02 grafik

JordanDIG commented 2 years ago

Interesting, thank you @scubamuc - this would mean the issue is not in the code base. @jaycedk @JordanDIG can you give it a try?

I have to deactivate and reactivate the application, right?

scubamuc commented 2 years ago

@JordanDIG yip, thats how I did it

JordanDIG commented 2 years ago

This does not work for me.

scubamuc commented 2 years ago

@pierre-alain-b ... obviously a shot in the dark...

pierre-alain-b commented 2 years ago

Well, I've made a thorough comparison of ALL the changes between the versions. I found one place which could explain the faulty behavior. See here: https://github.com/pierre-alain-b/rainloop-nextcloud/commit/449cfadaa77f1f1197bc43ec9fd92ad2c6ee0a4d

Any chance one of you may test this change?

There is one line to change in the app/rainloop/v/1.16.0/app/libraries/RainLoop/Utils.php file.

scubamuc commented 2 years ago

@pierre-alain-b , sorry no chance to test on Nextcloud-Snap, files are containered. on hosted instance my workaround seems to work still.

scubamuc commented 2 years ago

@pierre-alain-b , done! success: grafik

grafik

this works for Nextcloud-Snap 23.02

Dropdown is now visible, thank you for your help

pierre-alain-b commented 2 years ago

Excellent, thank you for the test! I will ship 7.2.2 with the correction ASAP!

JordanDIG commented 2 years ago

I must have made a mistake because it does not work in my home... I will try again after the update

JordanDIG commented 2 years ago

@pierre-alain-b , done! success: grafik

grafik

this works for Nextcloud-Snap 23.02

Dropdown is now visible, thank you for your help

I just remade, I don't have a contact icon next to the source email address

jaycedk commented 2 years ago

Thank you @pierre-alain-b that made it work again :)

JordanDIG commented 2 years ago

After setting owncloud_suggestions to off it works again thanks for everything @pierre-alain-b

pierre-alain-b commented 2 years ago

7.2.2 has just been released. Please update and let me know if it works. If it does, we will then close the ticket. Thanks to everyone for testing/reporting and for your patience and support.

daniu-de commented 2 years ago

works - thanks - didn't even know that feature but it is surely very useful

pierre-alain-b commented 2 years ago

Closing on the first report that it works. Good to end the week with this off the plate!