search

pierre-vigier / Perl6-Data-MessagePack

Message pack implementation for perl6 / msgpack.org[Perl 6]
Artistic License 2.0
5 stars 8 forks source link

Tests failing with MoarVM hash changes #13

Closed samcv closed 6 years ago

samcv commented 6 years ago

With the recent MoarVM changes the hashes don't always return in a constant order (even without these changes it means that the tests probably wouldn't pass on perl6 running other VM backends).

Failures are in t/107-pack-hash.t, in which I get up to 2 failing tests (it can fail less if for that particular run of MoarVM it just so happens to return the previous order that the test expected).

AlexDaniel commented 6 years ago

https://cry.nu/perl6/secure-hashing-for-moarvm/

pierre-vigier commented 6 years ago

Fixed now, thanks for the notice. Instead of checking the blob byte by byte, i pack, unpack and check the result against the original hash