search

pierre3 / PlantUmlClassDiagramGenerator

This is a generator to create a class-diagram of PlantUML from the C# source code.
MIT License
683 stars 133 forks source link

In VSCode, output path is relative to input path, not workspace folder #26

Closed stanwest closed 4 years ago

stanwest commented 4 years ago

Thank you for the extension to Visual Studio Code.

The description of the csharp2plantuml.outputPath configuration option states that its value is relative to the workspace folder. However, the actual behavior (from this line) is that the output folder option is relative to the input folder. Please consider resolving the conflict in favor of the documentation, such that the value is relative to the workspace folder.

Vivraan commented 4 years ago

Fixing this in a PR.

Vivraan commented 4 years ago

Meanwhile, in your pierre3.csharp-to-plantuml-x.x.x\extension.js, change this:

        if (outputPath !== "") {
            command += ` "${path_1.join(input, outputPath)}"`;
        }

to this:

        if (outputPath !== "") {
            command += ` "${path_1.join(wsroot, outputPath)}"`;
        }
pierre3 commented 4 years ago

@Vivraan Merged. Thank you for your PR!