search

pierre3 / PlantUmlClassDiagramGenerator

This is a generator to create a class-diagram of PlantUML from the C# source code.
MIT License
683 stars 133 forks source link

Bug fix: AttributeRequired not working in Directory based Generation #74

Closed tyagi closed 1 year ago

tyagi commented 1 year ago

Thanks for maintaining this useful tool!

AttributeRequired flag does not work when input is directory instead of a file.

RootCause: Bug in Program.cs GeneratePlantUmlFromDir method where wrong flag name(ignoreEmptyModifier) is used. There is no reference to ignoreEmptyModifier in the whole repository except at this place. I presume it is orphan artefact which slipped in from local development.

Fix: Change -ignoreEmptyModifer to -attributeRequired similar to how GeneratePlantUmlFromFile handles it.

tyagi commented 1 year ago

@pierre3 Requesting your attention here!

pierre3 commented 1 year ago

@tyagi Merged. Thank you for your contribution!

pierre3 commented 1 year ago

@tyagi Thank you for your patience. We have released version 1.3.4 with the applied fix.