pierrec / lz4

LZ4 compression and decompression in pure Go
BSD 3-Clause "New" or "Revised" License
878 stars 142 forks source link

lz4 reader: expose Frame.ParseHeader via ValidFrameHeader in reader #147

Closed 10000TB closed 3 years ago

10000TB commented 3 years ago

...for user cases where one needs to pre-check if the incoming stream match lz4 header.

10000TB commented 3 years ago

FIX #145

10000TB commented 3 years ago

@greatroar, @pierrec, PTAL

10000TB commented 3 years ago

@greatroar, @pierrec, @lizthegrey PTAL, thank you - david

greatroar commented 3 years ago

I don't think CheckLZ4 is a good name for this function. ValidFrameHeader?

10000TB commented 3 years ago

I don't think CheckLZ4 is a good name for this function. ValidFrameHeader?

Sure. Done.

PTAL again, and approve if all looks good.

10000TB commented 3 years ago

THx! can the workflow be approved also ? -- I cant seem do that

lizthegrey commented 3 years ago

Needs Pierre to approve.