Closed Josh-Cena closed 2 years ago
would still be useful to allow excluding some globals?
I don't think that's necessarily the goal of this module and I frankly can't see how that's useful after this bug is fixed😅 Since we have a forked SSG plugin, if you really want to exclude some globals, just use includeGlobals=false
and use the more verbose scope
instead. WDYT?
Follow-up of #27. Fix #29
Case as where #27 failed:
Because the
globalThis
in this case is an exotic object, the latterPrism
isn't actually made a "global".Logs
false
becauseObject
is exotic. RemovingObject
from the scope causes it to logtrue
.The resolution is to filter out anything that's already in the VM scope.
cc @pierrec This is a hotfix. cc @slorber FYI