includeGlobals is not true by default

pierrec / node-eval

Evaluate node require() module content directly

MIT License

93 stars 20 forks source link

Closed Zacqary closed 9 years ago

Zacqary commented 9 years ago

Is this a mistake in the readme or a mistake in the code?

markdalgleish commented 9 years ago

Came here to raise the exact same issue. Happy to send a PR to fix the code or documentation, I just don't know which is correct.

pierrec commented 9 years ago

It should be false by default. The README is wrong. I dont have access to git right now, if you could pull in a fix, it would be much appreciated! :)