search

pierrec / node-lz4

LZ4 fast compression algorithm for NodeJS
MIT License
438 stars 98 forks source link

Please rebuild for node 16 and release NAPI changes #115

Open templela opened 2 years ago

templela commented 2 years ago

The changes have been made but a release hasn't happened yet. That would be really appreciated.

vbatr commented 2 years ago

@pierrec, is there a chance to get this library for newer node version?

jubesab commented 1 year ago

@pierrec It would be fantastic if you could update this package to work with newer version of nodes!

pierrec commented 1 year ago

Hello, sorry for the late response. I am no longer using Node and not following its updates/developments anymore. I would accept a PR though to fix this issue!

jubesab commented 1 year ago

@pierrec I would happily contribute but I do not have the know how, unfortunately.

Pysis868 commented 3 months ago

@templela Can you link commits?

Pysis868 commented 3 months ago

@templela This one? a51c9e9edf2f6ebc19ac26b1a1968c3d9f25c594. There seem to be other useful commits already added to master too, which is probably what you were referring to. Head is 943e768691a9fb29e2d9a88f9942463765a45468.

@pierrec Can you add a tag along with an NPM package update and build included? I have this example if it helps: https://github.com/Pysis868/node-lz4/releases/tag/v0.6.8 I'm still trying to get it to install into the other project successfully though.. The latest version was branched, and not merged into master, so I tried to unify it all. I only upgraded the patch version number since only project internals/dependencies were changed, but maybe could warrant minor version upgrade(s) instead.

I arrived at this issue, looking for others, because another project required this one, where the latest version is 0.6.5, but building responded with errors like this:

  lz4_binding.cc
.../node-lz4\node_modules\nan\nan_callbacks .h(55,23): error C2039: 'AccessorSignature': is not a member of 'v8' [D:\Documents\Programmi ng\Others\Internet\Programming\node-lz4\build\lz4.vcxproj]

https://github.com/nodejs/nan/issues/942