search

pierrec / node-lz4

LZ4 fast compression algorithm for NodeJS
MIT License
438 stars 98 forks source link

Nanify and update dependencies - move to v0.4.0 #27

Closed EricMCornelius closed 9 years ago

EricMCornelius commented 9 years ago

This ports binding code over to use NaN, which is currently the most popular mechanism to provide abstraction over breaking v8/node api changes. Verified that unit tests pass for node v0.11/v0.12 and iojs v1.6.

pierrec commented 9 years ago

Fantastic work!

Thanks a lot for this pull, I had a few people asking for node 0.12 support but no time to do it ;).

EricMCornelius commented 9 years ago

I'm not sure it's 100% functional, continued testing shows a double free is occurring under certain conditions, but it's certainly a dent.

I'd hold off cutting another npm release just yet