search

pierrec / node-lz4

LZ4 fast compression algorithm for NodeJS
MIT License
438 stars 98 forks source link

install script overwrites build/lz4.js #95

Open MPickfield opened 4 years ago

MPickfield commented 4 years ago

The script "install": "node-gyp rebuild", in the package.json overwrites build/lz4.js on install, meaning that when you npm install the package the web version may be unavailable.

This may only have been an issue for me because I have a hybrid webpack project that outputs both a node-based cli tool and a browser ready package.

A solution could be to change the browserify output to another folder and change the "browser" entry in package.json to point there instead. build/ could then be added to .gitignore so that the node build doesn't accidentally get added.

pierrec commented 4 years ago

Thanks for reporting. Please send a PR if you need it.