pierrecdn / phpipam

phpIPAM Docker image
GNU Lesser General Public License v3.0
94 stars 111 forks source link

Added support for SNMP scans #19

Closed isaqueprofeta closed 6 years ago

isaqueprofeta commented 6 years ago

Now everything is fine on my eyes:

To test the SNMP support I used the network emulator GNS3 and added a device on phpipam, and then scanned the device for data with success (got some errors on VRF and VTP scans, but it's not library related, because of the emulation restrictions).

Please, feel free to make your own tests, any questions just ask.

Thanks for the image by the way, it was helping me a lot!

isaqueprofeta commented 6 years ago

Please review my answers and check the new commit I pushed.

FYI: I managed to get image to work with php7.2 (all libraries tested as I told before) but got heavy load of Warnings about code, here's the Dockerfile if you wanna test: gist

pierrecdn commented 6 years ago

About PHP 7.2, yes I observed the same. It didn't look very satisfying, so I postponed it. Feel free to open a new PR about that if you have the opportunity to work on it. Thanks!

pierrecdn commented 6 years ago

BTW, didn't notice that before merging, but for next time, you should have squashed your last 2 commit together.

isaqueprofeta commented 6 years ago

Sorry about forgeted squash, thanks for the head's up.