Add fping / update README with discover & ping

pierrecdn / phpipam

phpIPAM Docker image

GNU Lesser General Public License v3.0

94 stars 111 forks source link

Add fping / update README with discover & ping #21

Closed ElGranLoky closed 6 years ago

ElGranLoky commented 6 years ago

Sorry I create a new pull, i don't know how to clear the older one.

Add fping in the container (fast discover)
Some clean space with apt-get not install recommends example in the link
Add readme for make ping and discovery

If you use a docker orchestrator, you can use the same container image to program the image with a cron job, so you do not have to modify the container at any time and launch 3 containers:

1.- PHPIPAM 2.- PING 3.- DISCOVER

and divide the process.

I do not know if the explanation has been clear, if something is missing, you tell me.

pierrecdn commented 6 years ago

Hi, Thanks for your PR, that's very appreciated.

Unfortunately, I don't understand the added value of doing this for this general purpose phpipam container. To me these discover features are interesting if they are scheduled using phpipam itself, through the WebUI. Please explain a bit more what would be your use-case.

Also please try to only modify what's needed when doing a PR (the EOL spaces are maybe bad but they aren't part or the PR which focus on introduce something new and not to clean the existing code).

Regards,

ElGranLoky commented 6 years ago

Hi,

I do not understand how I can program the discovery service through the WebU. I have not found any field, where I can put the scheduled. Meanwhile, if it can be done without deploy another image or without making modifications, I think it is interesting.

Regarding the EOL spaces, I'm sorry, it's because using ATOM, is an automatic functionality.

Regards,

pierrecdn commented 6 years ago

Hi, I had an issue opened about people not being able to use the ICMP discover in 1.3.2 and added iputils-ping in 8ef7c15 to fix that. So, I'm now seeing your use-case as a duplicate, and fping would not be better suited to fix this issue. It answers your specific need so I encourage you to build your own container by doing a FROM pierrecdn/phpipam. Thanks anyway for the report & PR!