search

pierrecdn / phpipam

phpIPAM Docker image
GNU Lesser General Public License v3.0
94 stars 111 forks source link

Removing trailing slashes from source urls #28

Closed xsak closed 6 years ago

xsak commented 6 years ago

Trailing slash ended in double slashes in gitlab URLs which would not download somehow. Removing them allows to build the docker image.

pierrecdn commented 6 years ago

Hi,

Thanks for this PR. I don't understand what is actually preventing you from building this Docker image due to double slashes? This image is built on the Docker Hub without any issue, same on a local environment using docker build.

I don't mind merging this, but I would like to understand a bit more your context first.

Thanks,

pierrecdn commented 6 years ago

I'm closing for now, feel free to reopen & explain the issue here.