Missing underscore in GMAPS_API_KEY variable from README

pierrecdn / phpipam

phpIPAM Docker image

GNU Lesser General Public License v3.0

94 stars 111 forks source link

Missing underscore in GMAPS_API_KEY variable from README #64

Closed mariusmotea closed 4 years ago

pierrecdn commented 4 years ago

Hi, thanks for this, Could you just polish the commit message & body ("Fix typo on environment variable" and "GMAPS_API_KEY missed the underscore in the readme" for example)? Then I'll merge it right away.

mariusmotea commented 4 years ago

From mobile it don't allow me to edit the name, i will try in a few hours from my pc.

mariusmotea commented 4 years ago

Done! Hope it is ok now.

pierrecdn commented 4 years ago

I was more thinking of amending the commit itself, not the PR ;). It's easier to backlog things with git and avoid scrolling github issues all the day.