pierredavidbelanger / chatter-bot-api

A Mono/.NET, JAVA, Python and PHP chatter bot API that supports Cleverbot, JabberWacky and Pandorabots.
182 stars 71 forks source link

Not in Packagist #24

Open lesmo opened 8 years ago

lesmo commented 8 years ago

Hi, so... the PHP version is not in the Packagist repository. I know it's not a big deal, but is it ever going to happen? Seeing that there's a composer.json file I thought there would be an entry already.

pierredavidbelanger commented 8 years ago

Hi, the php tree is a kind of mess right now.

The most up-to-date code is in the chatterbotapi.php single file.

But the Packagist compatible version is in the php/src, this is where composer.json point.

Also, the composer.json is missing mandatory fields (see: packagist.org/about).

All of this will need a great cleanup before I can publish it.

PeeHaa commented 7 years ago

Are you willing to separate out the thing into it's dedicated chatter-bot-api-php repo?

I would like it to have a dedicated packagist package.

pierredavidbelanger commented 7 years ago

@PeeHaa this move is something that tickle me for a long time.

And since you talk about it now, I guess I am willing to do this move soon.

Do you have suggestions for me ?

How do you see the layout of this repository ?

One thing that bugs me most right now is the fact that my PHP version is a mess, and not standard PHP (at least not standard Packagist).

pierredavidbelanger commented 7 years ago

Is it mandatory that I refactor to be more object oriented like this ?

Or, do you think this simple file can be distributed through Packagist ?

PeeHaa commented 7 years ago

I think you can distribute a single file too using packagist using the autoload directive:

"autoload": {
    "files": ["chatterbotapi.php"]
}

But I am not 100% tbh. FWIW for me personally it's not that urgent anymore because for my current project I needed something that uses a non blocking http client either way. So I built my own implementation of cleverbot.

For other users it will still be very nice to be able to composer the project in to be able to use it.

I could do a test for you if you want me to with a single file.

pierredavidbelanger commented 7 years ago

@PeeHaa I like your implementation! You are clearly better than me at PHP :)

Thank you for the hint.