search

pierredavidbelanger / chatter-bot-api

A Mono/.NET, JAVA, Python and PHP chatter bot API that supports Cleverbot, JabberWacky and Pandorabots.
181 stars 72 forks source link

fix issue #19 Problem with Jabberwacky #25

Closed ghost closed 7 years ago

ghost commented 8 years ago

I used Jsoup to fix the Jabberwacky issue.

pierredavidbelanger commented 8 years ago

Thank you for this PR!

I really like the jsoup lib. And, in general in my own projects, I am a huge advocate of not re-inventing the wheel.

But, this particular project was dependency-less from the start. I fear users will complain about this change.

On the other hand, in the future, I really wanted to clean the code (and make it more solid), and use as much as possible what already exists (ie: HttpClient, jsoup).

I have mixed feelings. I will think about it a little.

pierredavidbelanger commented 7 years ago

Thanks for your effort, but I will not merge this. see this comment.