search

pierremolinaro / acan-esp32

An ESP32 CAN 2.0B library
MIT License
40 stars 16 forks source link

Transmit and Receive Buffer Peak Counts #3

Closed JohnGENZ closed 2 years ago

JohnGENZ commented 2 years ago

Congratulations on a well written library. It would be great to have a method to reset the Transmit and Receive Buffer Peak Counts. Do you have a recommended way to do this?

pierremolinaro commented 2 years ago

Thank you very much for your congratulations!

I can easily add a resetDriverTransmitBufferPeakCount method to the ACAN_ESP32 class that assign the transmit buffer current message count to the peak message count ; and a similar resetDriverReceiveBufferPeakCount method.

Does this suit you? If so, I will update the library.

Pierre

Le 11 févr. 2022 à 22:25, JohnGENZ @.***> a écrit :

Congratulations on a well written library. It would be great to have a method to reset the Transmit and Receive Buffer Peak Counts. Do you have a recommended way to do this?

— Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/acan-esp32/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWKZVDGEQKEHJU7UKXGZMDU2V5ERANCNFSM5OFMEEDQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.

JohnGENZ commented 2 years ago

Hi Pierre

That will work very well. Thank you very much.

Kind Regards,

John Errington.

From: Pierre Molinaro @.> Sent: Monday, 14 February 2022 3:12 AM To: pierremolinaro/acan-esp32 @.> Cc: JohnGENZ @.>; Author @.> Subject: Re: [pierremolinaro/acan-esp32] Transmit and Receive Buffer Peak Counts (Issue #3)

Thank you very much for your congratulations!

I can easily add a resetDriverTransmitBufferPeakCount method to the ACAN_ESP32 class that assign the transmit buffer current message count to the peak message count ; and a similar resetDriverReceiveBufferPeakCount method.

Does this suit you? If so, I will update the library.

Pierre

Le 11 févr. 2022 à 22:25, JohnGENZ @.***> a écrit :

Congratulations on a well written library. It would be great to have a method to reset the Transmit and Receive Buffer Peak Counts. Do you have a recommended way to do this?

— Reply to this email directly, view it on GitHub < https://github.com/pierremolinaro/acan-esp32/issues/3>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEWKZVDGEQKEHJU7UKXGZMDU2V5ERANCNFSM5OFMEEDQ . Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/acan-esp32/issues/3#issuecomment-1038145764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLCEUALSH6MDZHO55X4YJ3U2634TANCNFSM5OFMEEDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: < @.***>

pierremolinaro commented 2 years ago

Hi John,

I'm doing the update (1.0.6) before the end of the day.

Kind Regards,

Pierre

Le 13 févr. 2022 à 18:48, JohnGENZ @.***> a écrit :

Hi Pierre

That will work very well. Thank you very much.

Kind Regards,

John Errington.

From: Pierre Molinaro @.> Sent: Monday, 14 February 2022 3:12 AM To: pierremolinaro/acan-esp32 @.> Cc: JohnGENZ @.>; Author @.> Subject: Re: [pierremolinaro/acan-esp32] Transmit and Receive Buffer Peak Counts (Issue #3)

Thank you very much for your congratulations!

I can easily add a resetDriverTransmitBufferPeakCount method to the ACAN_ESP32 class that assign the transmit buffer current message count to the peak message count ; and a similar resetDriverReceiveBufferPeakCount method.

Does this suit you? If so, I will update the library.

Pierre

Le 11 févr. 2022 à 22:25, JohnGENZ @.***> a écrit :

Congratulations on a well written library. It would be great to have a method to reset the Transmit and Receive Buffer Peak Counts. Do you have a recommended way to do this?

— Reply to this email directly, view it on GitHub < https://github.com/pierremolinaro/acan-esp32/issues/3>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEWKZVDGEQKEHJU7UKXGZMDU2V5ERANCNFSM5OFMEEDQ . Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/acan-esp32/issues/3#issuecomment-1038145764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLCEUALSH6MDZHO55X4YJ3U2634TANCNFSM5OFMEEDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: < @.***> — Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/acan-esp32/issues/3#issuecomment-1038294907, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWKZVB6ETG6LWUJSVQDTFLU27VIVANCNFSM5OFMEEDQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

JohnGENZ commented 2 years ago

Hi Pierre

Many thanks. I have installed V1.0.6 and it works well.

FYI I am prototyping a group of PID controllers that work together over CAN bus. Being able to reset these counters helps to tune the "swarm".

Kind Regards John E.