pierremolinaro
commented
3 years ago Hello,
I think it is better to write frame.data [i] = msg[i] ; instead of frame.data [i] = {msg[i]} ;
What do you mean by "failure" ? does the send process stop ?
Note a CAN controller should not be alone on a CAN bus. When a CAN controller sends a frame, it require an ACK from a receiver. No receiver, no ack. It is a failure for the CAN controller, so it sends again the frame. So an alone CAN controller sends repetitivly the same frame, without emptying the hardware send buffer. Next messages are stored in the driver send buffer. So the driver accepts messages until its send buffer is not full. So 17 messages are accepted (1 in the MCP2515 hadrware buffer, 16 in the driver send buffer).
Best regards,
Pierre Molinaro
Le 2 oct. 2020 à 19:31, Mplex72 notifications@github.com a écrit :
What did I do wrong within this sketch on arduino UNO? it will send only 17 meassages , then I have "failure" in the serial interface .
< / */
include
static const byte MCP2515_CS = 10 ; // CS input of MCP2515 (adapt to your design) static const byte MCP2515_INT = 3 ; // INT output of MCP2515 (adapt to your design)
ACAN2515 can (MCP2515_CS, SPI, MCP2515_INT) ;
static const uint32_t QUARTZ_FREQUENCY = 8UL 1000UL 1000UL ; // 8 MHz
void setup() {
Serial.begin (38400) ;
while (!Serial) { delay (50) ; digitalWrite (LED_BUILTIN, !digitalRead (LED_BUILTIN)) ; } SPI.begin () ;
ACAN2515Settings settings (QUARTZ_FREQUENCY, 500UL * 1000UL) ; // CAN bit rate 500 kb/s const uint16_t errorCode = can.begin (settings, [] { can.isr () ; }) ; if (errorCode == 0) { Serial.print ("Bit Rate prescaler: ") ; Serial.println (settings.mBitRatePrescaler) ; Serial.print ("Propagation Segment: ") ; Serial.println (settings.mPropagationSegment) ; Serial.print ("Phase segment 1: ") ; Serial.println (settings.mPhaseSegment1) ; Serial.print ("Phase segment 2: ") ; Serial.println (settings.mPhaseSegment2) ; Serial.print ("SJW: ") ; Serial.println (settings.mSJW) ; Serial.print ("Triple Sampling: ") ; Serial.println (settings.mTripleSampling ? "yes" : "no") ; Serial.print ("Actual bit rate: ") ; Serial.print (settings.actualBitRate ()) ; Serial.println (" bit/s") ; Serial.print ("Exact bit rate ? ") ; Serial.println (settings.exactBitRate () ? "yes" : "no") ; Serial.print ("Sample point: ") ; Serial.print (settings.samplePointFromBitStart ()) ; Serial.println ("%") ; }else{ Serial.print ("Configuration error 0x") ; Serial.println (errorCode, HEX) ; } } static uint32_t gBlinkLedDate = 0 ; static uint32_t gReceivedFrameCount = 0 ; static uint32_t gSentFrameCount = 0 ; byte msg[8] = {0, 0, 0, 0, 0, 0, 0, 0};
void loop() {
byte msg[8] = { 12, 23, 33, 44, 55, 66, 77, 28};
CANMessage frame ; frame.id = 31 ; frame.ext = true ; frame.rtr = false ; frame.idx = 0 ; frame.len = 8 ; for (int i=0 ; i<8 ; i++) { frame.data [i] = {msg[i]} ; } / frame.data [0] = {egt[1]} ; frame.data [1] = {egt[2]} ; frame.data [2] = 33 ; frame.data [3] = 44 ; frame.data [4] = 55 ; frame.data [5] = 66 ; frame.data [6] = 77 ; frame.data [7] = 88 ; / if (gBlinkLedDate < millis ()) { gBlinkLedDate += 50 ; digitalWrite (LED_BUILTIN, !digitalRead (LED_BUILTIN)) ; const bool ok = can.tryToSend (frame) ; if (ok) { gSentFrameCount += 1 ; Serial.print ("Sent: ") ; Serial.println (gSentFrameCount) ; }else{ Serial.println ("Send failure") ; } } }
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/acan2515/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWKZVC2CPKH5SHVN6EBNPTSIYE7HANCNFSM4SB6UJNA.
Mplex72
obdevel
What did I do wrong within this sketch on arduino UNO? it will send only 17 meassages , then I have "failure" in the serial interface .
< /*
*/
include
static const byte MCP2515_CS = 10 ; // CS input of MCP2515 (adapt to your design) static const byte MCP2515_INT = 3 ; // INT output of MCP2515 (adapt to your design)
ACAN2515 can (MCP2515_CS, SPI, MCP2515_INT) ;
static const uint32_t QUARTZ_FREQUENCY = 8UL 1000UL 1000UL ; // 8 MHz
void setup() {
Serial.begin (38400) ;
while (!Serial) { delay (50) ; digitalWrite (LED_BUILTIN, !digitalRead (LED_BUILTIN)) ; } SPI.begin () ;
ACAN2515Settings settings (QUARTZ_FREQUENCY, 500UL * 1000UL) ; // CAN bit rate 500 kb/s const uint16_t errorCode = can.begin (settings, [] { can.isr () ; }) ; if (errorCode == 0) { Serial.print ("Bit Rate prescaler: ") ; Serial.println (settings.mBitRatePrescaler) ; Serial.print ("Propagation Segment: ") ; Serial.println (settings.mPropagationSegment) ; Serial.print ("Phase segment 1: ") ; Serial.println (settings.mPhaseSegment1) ; Serial.print ("Phase segment 2: ") ; Serial.println (settings.mPhaseSegment2) ; Serial.print ("SJW: ") ; Serial.println (settings.mSJW) ; Serial.print ("Triple Sampling: ") ; Serial.println (settings.mTripleSampling ? "yes" : "no") ; Serial.print ("Actual bit rate: ") ; Serial.print (settings.actualBitRate ()) ; Serial.println (" bit/s") ; Serial.print ("Exact bit rate ? ") ; Serial.println (settings.exactBitRate () ? "yes" : "no") ; Serial.print ("Sample point: ") ; Serial.print (settings.samplePointFromBitStart ()) ; Serial.println ("%") ; }else{ Serial.print ("Configuration error 0x") ; Serial.println (errorCode, HEX) ; } } static uint32_t gBlinkLedDate = 0 ; static uint32_t gReceivedFrameCount = 0 ; static uint32_t gSentFrameCount = 0 ; byte msg[8] = {0, 0, 0, 0, 0, 0, 0, 0};
void loop() {
byte msg[8] = { 12, 23, 33, 44, 55, 66, 77, 28};
CANMessage frame ; frame.id = 31 ; frame.ext = true ; frame.rtr = false ; frame.idx = 0 ; frame.len = 8 ; for (int i=0 ; i<8 ; i++) { frame.data [i] = {msg[i]} ; }
/ frame.data [0] = {egt[1]} ; frame.data [1] = {egt[2]} ; frame.data [2] = 33 ; frame.data [3] = 44 ; frame.data [4] = 55 ; frame.data [5] = 66 ; frame.data [6] = 77 ; frame.data [7] = 88 ;
/
if (gBlinkLedDate < millis ()) { gBlinkLedDate += 50 ; digitalWrite (LED_BUILTIN, !digitalRead (LED_BUILTIN)) ; const bool ok = can.tryToSend (frame) ; if (ok) { gSentFrameCount += 1 ; Serial.print ("Sent: ") ; Serial.println (gSentFrameCount) ; }else{ Serial.println ("Send failure") ; } } }