search

pierremolinaro / acan2517FD

Distribution of Arduino driver for MCP2517FD CAN controller (CANFD mode)
MIT License
70 stars 17 forks source link

Possible Bug regarding Retransmission Setting #15

Closed Flole998 closed 4 years ago

Flole998 commented 4 years ago

The datasheet of the MCP2518FD says on page 27:

RTXAT: Restrict Retransmission Attempts bit( 1) 1 = Restricted retransmission attempts, CiFIFOCONm.TXAT is used 0 = Unlimited number of retransmission attempts, CiFIFOCONm.TXAT will be ignored

Current code says: data8 = mUsesTXQ ? (1 << 4) : 0x00 ; // Bug fix in 1.1.4 (thanks to danielhenz) I changed it to

data8 = 0x01 ; //Enable RTXAT to limit retransmissions (Flole)
data8 |= mUsesTXQ ? (1 << 4) : 0x00 ; // Bug fix in 1.1.4 (thanks to danielhenz)

Do I see that correctly that right now RTXAT is not set, causing the retransmissions to be always unlimited and the code should be modified just as I did it above?

pierremolinaro commented 4 years ago

Hello,

Yes, your code sets the RTXAT bit. This enables the CiFIFOCONm.TXAT bits to control retransmission. As these bits remain clear, retransmission attempts are disabled.

Best regards,

Pierre

Le 28 mai 2020 à 23:04, Flole998 notifications@github.com a écrit :

The datasheet of the MCP2518FD says on page 27:

RTXAT: Restrict Retransmission Attempts bit( 1) 1 = Restricted retransmission attempts, CiFIFOCONm.TXAT is used 0 = Unlimited number of retransmission attempts, CiFIFOCONm.TXAT will be ignored

Current code says: data8 = mUsesTXQ ? (1 << 4) : 0x00 ; // Bug fix in 1.1.4 (thanks to danielhenz) I changed it to

data8 = 0x01 ; //Enable RTXAT to limit retransmissions (Flole) data8 |= mUsesTXQ ? (1 << 4) : 0x00 ; // Bug fix in 1.1.4 (thanks to danielhenz) Do I see that correctly that right now RTXAT is not set, causing the retransmissions to be always unlimited and the code should be modified just as I did it above?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/acan2517FD/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWKZVBABI74AVYGP76EVRLRT3GVDANCNFSM4NNNS5CQ.

Flole998 commented 4 years ago

That would mean for this library that we should add my modification, as we set the TXAT Bits based on the users selection. In the current version we are always doing unlimited retransmissions, even though the options for three retransmissions or no retransmissions are set.

pierremolinaro commented 4 years ago

Ok, I do the modifications, and will publish the release tomorrow or on monday.

Best regards,

Pierre Molinaro

Le 30 mai 2020 à 20:47, Flole998 notifications@github.com a écrit :

That would mean for this library that we should add my modification, as we set the TXAT Bits based on the users selection. In the current version we are always doing unlimited retransmissions, even though the options for three retransmissions or no retransmissions are set.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/acan2517FD/issues/15#issuecomment-636369565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWKZVFJ3Y7OIWHUI5UGVM3RUFICXANCNFSM4NNNS5CQ.

Flole998 commented 4 years ago

Thank you very much!