pierremtb / easy-fit

Parse your .FIT files easily, directly from JS
Other
70 stars 51 forks source link

avg_stance_time_percent seems to have incorrect value #30

Open svrpeakers opened 5 years ago

svrpeakers commented 5 years ago

avg_stance_time_percent seems to have incorrect value. supposed to denote AVG Ground Contact Time Balance but seems to be off for some reason

jimmykane commented 5 years ago

Could you try my fork and lets continue there? I think @pierremtb is a bit busy the latest time

https://github.com/jimmykane/fit-parser

svrpeakers commented 5 years ago

Will do right away and let you know what happens

jimmykane commented 5 years ago

At least I am trying to maintain this lib in a fork. I am picking up issues also from here, but would be great if it's not fixed to report back :-)

svrpeakers commented 5 years ago

So the avg_stance_time_percent is still incorrect it seems (unless I am somehow calculating wrong. In the connect app the value is L 50.1 % / R 49.9% and I'm getting "avg_stance_time_percent":36.51, "avg_stance_time":274.3,

The stance time is correct (274ms) but the percentage is off (unless I'm somehow using it wrong)

svrpeakers commented 5 years ago

any idea @jimmykane

jimmykane commented 5 years ago

I ll get back to this. Have not forgotten you. Need to get some free time :-)

On Thu, Mar 28, 2019 at 7:19 PM svrpeakers notifications@github.com wrote:

any idea @jimmykane https://github.com/jimmykane

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pierremtb/easy-fit/issues/30#issuecomment-477715077, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNb85B8VM_mtUHnypjk-jAj5Fx_UMrsks5vbQfPgaJpZM4cEhf7 .

svrpeakers commented 5 years ago

ok no worries, thanks :)

jimmykane commented 5 years ago

@svrpeakers Can you provide a fit file to test against? Thanks!

svrpeakers commented 5 years ago

file.txt

Here is the fit file. had to name it txt for upload

jimmykane commented 5 years ago

Thanks

jimmykane commented 5 years ago

I dont see any issue on the processing but I am also kind clueless about the avg_stance_time_percent. To me it looks like you are looking at avg_vertical_oscillation Could you elaborate?

svrpeakers commented 5 years ago

So i'm getting "avg_stance_time_percent":36.51 but in garmin connect I see a value of 50.1 % L and 49.9 % R So I'm expecting to see either 50.1 or maybe 36.51 is half in relation to some OTHER value. But I'm not sure what value.

avg_vertical_oscillation is 101.7 but I'm not interested in this value. do you get the same?

jimmykane commented 5 years ago

@svrpeakers are you maybe looking for avg_stance_time_balance ? I think that is missing from this importer. Looking at it.

jimmykane commented 5 years ago

@svrpeakers example on full decoded file

--- timestamp=921336141=2019-03-12T14:42:21Z
--- start_time=921333655=2019-03-12T14:00:55Z
--- start_position_lat=405952636=34.0265569 deg
--- start_position_long=-1413915656=-118.5130412 deg
--- total_elapsed_time=2455715=2455.715 s
--- total_timer_time=2400626=2400.626 s
--- total_distance=662501=6625.01 m
--- total_strides=3170=3170 strides
--- nec_lat=406016301=34.0318932 deg
--- nec_long=-1413708853=-118.4957072 deg
--- swc_lat=405835646=34.0167509 deg
--- swc_long=-1413920558=-118.5134521 deg
--- xxx38=405954756=405954756
--- xxx39=-1413915668=-1413915668
--- unknown110="Run"
--- xxx152=0=0
--- message_index=0=selected=0,reserved=0,mask=0
--- total_calories=425=425 kcal
--- avg_speed=2760=9.936 km/h
--- max_speed=3602=12.967 km/h
--- total_ascent=202=202 m
--- total_descent=240=240 m
--- first_lap_index=0=0
--- num_laps=1=1
--- avg_vertical_oscillation=1017=101.7 mm
--- avg_stance_time_percent=3651=36.51 %
--- avg_stance_time=2743=274.3 ms
--- unknown106=0=0
--- avg_vertical_ratio=981=9.81 %
--- avg_stance_time_balance=5007=50.07 %
--- avg_step_length=10226=1022.6 mm
--- xxx151=0=0
--- event=9=lap
--- event_type=1=stop
--- sport=1=running
--- sub_sport=0=generic
--- avg_heart_rate=137=137 bpm
--- max_heart_rate=153=153 bpm
--- avg_running_cadence=79=79 strides/min
--- max_running_cadence=89=89 strides/min
--- total_training_effect=20=2.0
--- trigger=0=activity_end
--- unknown81=0=0
--- avg_fractional_cadence=87=0.68 rpm
--- max_fractional_cadence=64=0.50 rpm
--- total_anaerobic_training_effect=0=0.0
--- xxx138=1=1,0
--- xxx184=0=0
jimmykane commented 5 years ago

@svrpeakers I have patched my latest lib. Might worth giving it a try